From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6F0B17803E1 for ; Fri, 15 Mar 2024 09:53:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=713oCU52ULyz9rZ2IahZ7puLqQzrW57Q3t3HwWY8X3E=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710496416; v=1; b=EXZmOr6H55wI29n9QeluB3FK5DOAU+Xk98ksWwQUgq0lLD39lsQm3GZBeM/vL/xJfaKoJp0C Zybs9ATHTGZQ5jtuAXQ8TiH64nBqOtrWZd10axEm7NQ7dNOe0OPn6UmPyXZr289OSWTQX7u7LGt C6VnE4db1L7jaFuKh1VELJr07g7oGJsjXpEn9ytYfQc3s30ZjCufDpmLaSk+s0wAm9YS2p305Hg QhraOlb2Kh2lieXsD/6ot1LutYJbW5aBUdZzBox4w6fGe5ev0YmLuNgy/oEMgXlawZwSjjqLHlJ cQJVV6o1JddC7e5F+RiSqW9dAsnCu7FXvteRIZKYQuMzw== X-Received: by 127.0.0.2 with SMTP id Q8fHYY7687511x1GbZDQnISB; Fri, 15 Mar 2024 02:53:36 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.17802.1710496410357756306 for ; Fri, 15 Mar 2024 02:53:30 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-pG7rjNqSMtuBxD4MiJ5IJw-1; Fri, 15 Mar 2024 05:53:25 -0400 X-MC-Unique: pG7rjNqSMtuBxD4MiJ5IJw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B94A89C664; Fri, 15 Mar 2024 09:53:25 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 315752166B4F; Fri, 15 Mar 2024 09:53:25 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2AF161800DD4; Fri, 15 Mar 2024 10:53:24 +0100 (CET) Date: Fri, 15 Mar 2024 10:53:24 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, lichao@loongson.cn Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian , Xianglai Li Subject: Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093924.1254576-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240311093924.1254576-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:53:30 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GKRXdGWIDwTGm1517jkXAHlrx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=EXZmOr6H; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > This library for PEI phase, and obtains the QemuFwCfg base address by > directly parsing the FDT, reads and writes the data in QemuFwCfg by > operating on the QemuFwCfg base address. > create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/FdtQemuFwCfgPeiLib.c > create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/FdtQemuFwCfgPeiLib.inf > create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/QemuFwCfgLibInternal.h > create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/QemuFwCfgPei.c Is there anything LoongArch-specific in there? If not this can go to OvmfPkg/Library (and possibly used by arm and risc-v too). > + GuidHob = GetFirstGuidHob (&mFwCfgSelectorAddressGuid); This hob is not mentioned in the commit message. Please describe the changes in more detail. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116798): https://edk2.groups.io/g/devel/message/116798 Mute This Topic: https://groups.io/mt/104859897/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-