From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A98B9AC13B1 for ; Tue, 26 Mar 2024 15:45:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UneKyfJxKu7cxfU88+c+aT+8VqnBRoU0jcHR9ToPs8w=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1711467900; v=1; b=UpRO3Btnlvr/Weml9IwS8klm6JroYn54tDyDiz55Qkopfrvg9/JPlGS+y9H+TQ58T3Up8rwl PKsbUTLvoo3GHfgX+BaobX/YFGHwY89qz2/1aNCGYIpdSnwQVjEwCzO6Hs+/U0DbmEbE6nX/LJs GgzP4Ntnbwks5MrbFTvlAmI67jNpHofuHjiAthmbqjmwVTrDnBaFXNCpdOF+iepMK5dZp2RT3QZ V1cZy130J/cywlfR8KE6Jw09EujXMm2Svd+aMxmiQmSlzefSFJO2WYL2W9E0LC/jQBUZFVZt6nr gWRZyDONvvtunP/AVeoePZQMNXf/ErX0t4MFCcVEcCEFQ== X-Received: by 127.0.0.2 with SMTP id pMf1YY7687511xo9jGkqZA9J; Tue, 26 Mar 2024 08:45:00 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.12869.1711467899338851556 for ; Tue, 26 Mar 2024 08:44:59 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-wzmV_TJ7PYuMWZUv6u0_nA-1; Tue, 26 Mar 2024 11:44:55 -0400 X-MC-Unique: wzmV_TJ7PYuMWZUv6u0_nA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD4393C0E44F; Tue, 26 Mar 2024 15:44:54 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 968C73C20; Tue, 26 Mar 2024 15:44:54 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4E10B1801492; Tue, 26 Mar 2024 16:44:33 +0100 (CET) Date: Tue, 26 Mar 2024 16:44:33 +0100 From: "Gerd Hoffmann" To: "Sun, CepingX" Cc: "devel@edk2.groups.io" , "Aktas, Erdem" , "Yao, Jiewen" , "Xu, Min M" , "Reshetova, Elena" Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Message-ID: References: <4t224udqjvt4kfg45skznhrj6n2ftez3eumgjerblbhl3iwv4c@zbvo45wwqksj> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 08:44:59 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6j4BAjM1IQyGtVpHNkIayPvnx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UpRO3Btn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Mar 26, 2024 at 09:08:59AM +0000, Sun, CepingX wrote: > On Friday, March 22, 2024 5:06 PM Gerd Hoffmann wrote: > > > > No, we only need to update QemuFwCfgSelectItem + QemuFwCfgReadBytes to > > support reading from the cache. > Do you mean the existing API (QemuFwCfgSelectItem + QemuFwCfgReadBytes) need to be changed to support reading from the cache? > > If that is the case, there are some concerns as below: > 1: One or more new parameters (of QemuFwCfgReadBytes()) need to be added to search > the item in cache, which is equivalent to adding a new API. No. Yes, you need to maintain some extra state, so you know which item was selected most recently and how many bytes have been read already. It's not needed to task the caller with that though. Alternatively you can add fields to EFI_HOB_PLATFORM_INFO, or create a new HOB for that, and store the state there. That way QemuFwCfgReadBytes works properly with the cache without the caller passing in the state. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117129): https://edk2.groups.io/g/devel/message/117129 Mute This Topic: https://groups.io/mt/104880546/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-