From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 38467941CAE for ; Tue, 14 Nov 2023 14:52:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qZrB2T77Ud8TtMvwTBK5Zg1XgkckR7rQ9wmhUG4f6WY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699973520; v=1; b=ZfHuDQw3eYEcB3lbka+hweEq/j0OhZuQeQWQWf15Ti3wAZG8OG6bNIaZSYm0EHg+2M6O1y3U C+gdCeTjnRpCtr3kQpmcYxi6KAjVJyD/ZvO7svfd03tXGqxA/EaL+4EfNJ2poZ53deuci5aK+iu yzkpzEvkt1zPO2Mr0PhB3Cow= X-Received: by 127.0.0.2 with SMTP id kQjUYY7687511xZlGHomICOc; Tue, 14 Nov 2023 06:52:00 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.14405.1699973519975187162 for ; Tue, 14 Nov 2023 06:52:00 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-zFr4XJ08OQmnaZR0XJs2DA-1; Tue, 14 Nov 2023 09:51:55 -0500 X-MC-Unique: zFr4XJ08OQmnaZR0XJs2DA-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0131C811E91; Tue, 14 Nov 2023 14:51:55 +0000 (UTC) X-Received: from [10.39.194.106] (unknown [10.39.194.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9258A492BFD; Tue, 14 Nov 2023 14:51:53 +0000 (UTC) Message-ID: Date: Tue, 14 Nov 2023 15:51:52 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: Pedro Falcato , devel@edk2.groups.io Cc: Michael Kubacki , Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sUPfkC0ysZaYVFRypcTxwe2Ex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZfHuDQw3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/13/23 20:07, Pedro Falcato wrote: > On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote: >> >> Hi Michael, >> >> recently I encountered an uncrustify failure on github. >> >> The reason was that my local uncrustify was *more recent* (73.0.8) than >> the one we use in edk2 CI (which is 73.0.3, per the edk2 file >> ".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml"). > > Wait, you can use upstream uncrustify? I'm just using whatever > uncrustify version I took from the project-mu fork... Apologies -- for edk2 purposes (and I don't use uncrustify for anything else), I consider "upstream". > >> >> Updating the version number in the YAML file (i.e., advancing edk2 to >> version 73.0.8) seems easy enough, but: >> >> - Do you think 73.0.8 is mature enough for adoption in edk2? >> >> This upstream uncrustify release was tagged in April (and I can't see >> any more recent commits), so I assume it should be stable. >> >> - Would the version update require a whole-tree re-uncrustification? > > Please, no. I didn't mind doing an initial reformatting at first, but > doing this continuously is both 1) problem-prone 2) just amazing > amounts of churn. > Let's say I have version N, you have version N+1 - we may never get > any final, formatted output as your version formats it differently > from mine. Your argument against a continuously reformatted code base is well received; just a small correction: we should never have an N vs. N+1 dilemma. What CI uses is the authoritative version. > > I don't know how the CI is doing its thing atm (I haven't merged > anything myself to edk2), but the uncrustify check should be relaxed > to just a warning. I don't think that's going to happen. Everybody ignores warnings when in a rush, or when the same warnings pop up for the 10th time. > There's nothing wrong with what my uncrustify > version is formatting to, there's nothing wrong with yours either, and > CI isn't necessarily wrong either. > > And, to be fair, I already find uncrustify a large pain in the butt to > use (requiring a custom fork really does not help), but I find the > benefits worth it *locally*, as my coding style is also quite > different from the NT-esque style. Funnily enough, my stance is quite the opposite. I happen to disagree with some patterns that uncrustify enforces, but I'm thankful that at any given state of CI (= using any given version of uncrustify), we can't have any more debates about patch formatting (that is, it's especially its central nature that I like). I've found uncrustify relatively easy to use locally, too. All in all I'm not trying to upset the status quo, it's just a question about a version bump, and how we'd deal with any fallout from that. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111200): https://edk2.groups.io/g/devel/message/111200 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-