From: rebecca@bluestop.org
To: devel@edk2.groups.io, zhijux.fan@intel.com
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId
Date: Mon, 17 Jun 2019 13:05:27 -0600 [thread overview]
Message-ID: <f02a6e8d-db27-877e-4e5b-4e72704bd177@bluestop.org> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF82597@SHSMSX101.ccr.corp.intel.com>
On 2019-06-17 04:54, Fan, ZhijuX wrote:
> GenBiosId is a tool to generate the BIOS ID binary file which uses
> the data from the configuration file.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1846
pylama (https://github.com/klen/pylama) reports the following issues:
bcran@photon:~/workspace/edk2/BaseTools/Source/Python/GenBiosId % pylama .
GenBiosId.py:1:1: E266 too many leading '#' for block comment [pycodestyle]
GenBiosId.py:19:1: E722 do not use bare 'except' [pycodestyle]
GenBiosId.py:21:1: W0401 'from Common.BuildToolError import *' used;
unable to detect undefined names [pyflakes]
GenBiosId.py:22:1: W0401 'from Common.Misc import *' used; unable to
detect undefined names [pyflakes]
GenBiosId.py:23:1: W0401 'from Common.DataType import *' used; unable to
detect undefined names [pyflakes]
GenBiosId.py:24:1: W0611 'Common.BuildVersion.gBUILD_VERSION' imported
but unused [pyflakes]
GenBiosId.py:34:80: E501 line too long (82 > 79 characters) [pycodestyle]
GenBiosId.py:38:17: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:38:28: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:38:43: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:39:17: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:39:28: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:39:43: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:40:17: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:40:21: E201 whitespace after '{' [pycodestyle]
GenBiosId.py:40:29: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:40:44: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:41:17: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:41:28: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:41:43: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:41:44: E231 missing whitespace after ':' [pycodestyle]
GenBiosId.py:42:20: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:42:31: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:42:50: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:43:20: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:43:31: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:43:48: E203 whitespace before ':' [pycodestyle]
GenBiosId.py:49:80: E501 line too long (83 > 79 characters) [pycodestyle]
GenBiosId.py:53:1: E302 expected 2 blank lines, found 1 [pycodestyle]
GenBiosId.py:53:1: C901 'Main' is too complex (17) [mccabe]
GenBiosId.py:55:80: E501 line too long (90 > 79 characters) [pycodestyle]
GenBiosId.py:57:80: E501 line too long (81 > 79 characters) [pycodestyle]
GenBiosId.py:59:80: E501 line too long (102 > 79 characters) [pycodestyle]
GenBiosId.py:60:80: E501 line too long (97 > 79 characters) [pycodestyle]
GenBiosId.py:61:80: E501 line too long (110 > 79 characters) [pycodestyle]
GenBiosId.py:65:80: E501 line too long (86 > 79 characters) [pycodestyle]
GenBiosId.py:65:28: E225 missing whitespace around operator [pycodestyle]
GenBiosId.py:66:1: W0401 'OPTION_MISSING may be undefined, or defined
from star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:68:1: W0401 'OPTION_MISSING may be undefined, or defined
from star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:69:1: W0401 'FatalError may be undefined, or defined from
star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:69:1: W0612 local variable 'X' is assigned to but never
used [pyflakes]
GenBiosId.py:75:80: E501 line too long (86 > 79 characters) [pycodestyle]
GenBiosId.py:75:1: W0401 'FILE_NOT_FOUND may be undefined, or defined
from star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:80:80: E501 line too long (93 > 79 characters) [pycodestyle]
GenBiosId.py:80:1: W0401 'FORMAT_NOT_SUPPORTED may be undefined, or
defined from star imports: Common.BuildToolError, Common.DataType,
Common.Misc' [pyflakes]
GenBiosId.py:85:80: E501 line too long (93 > 79 characters) [pycodestyle]
GenBiosId.py:85:1: W0401 'FORMAT_INVALID may be undefined, or defined
from star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:88:80: E501 line too long (92 > 79 characters) [pycodestyle]
GenBiosId.py:88:1: W0401 'FORMAT_INVALID may be undefined, or defined
from star imports: Common.BuildToolError, Common.DataType, Common.Misc'
[pyflakes]
GenBiosId.py:91:80: E501 line too long (101 > 79 characters) [pycodestyle]
GenBiosId.py:91:1: W0401 'FORMAT_UNKNOWN_ERROR may be undefined, or
defined from star imports: Common.BuildToolError, Common.DataType,
Common.Misc' [pyflakes]
GenBiosId.py:95:80: E501 line too long (173 > 79 characters) [pycodestyle]
GenBiosId.py:96:80: E501 line too long (111 > 79 characters) [pycodestyle]
GenBiosId.py:96:14: E127 continuation line over-indented for visual
indent [pycodestyle]
GenBiosId.py:114:1: E305 expected 2 blank lines after class or function
definition, found 1 [pycodestyle]
GenBiosId.py:116:5: E266 too many leading '#' for block comment
[pycodestyle]
GenBiosId.py:117:24: E701 multiple statements on one line (colon)
[pycodestyle]
next prev parent reply other threads:[~2019-06-17 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 10:54 [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId Fan, ZhijuX
2019-06-17 17:18 ` Michael D Kinney
2019-06-18 13:14 ` Liming Gao
[not found] ` <15A94D43BBFC7A00.29221@groups.io>
2019-06-18 14:00 ` [edk2-devel] " Liming Gao
2019-06-17 19:05 ` rebecca [this message]
2019-06-18 13:26 ` Liming Gao
2019-06-18 21:03 ` rebecca
2019-06-17 19:11 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f02a6e8d-db27-877e-4e5b-4e72704bd177@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox