From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bluestop.org, ip: 96.73.9.1, mailfrom: rebecca@bluestop.org) Received: from muon.bluestop.org (muon.bluestop.org [96.73.9.1]) by groups.io with SMTP; Mon, 17 Jun 2019 12:05:29 -0700 Received: from muon.bluestop.org (localhost [127.0.0.1]) by muon.bluestop.org (Postfix) with ESMTP id B7FC96BC25; Mon, 17 Jun 2019 13:09:24 -0600 (MDT) Received: from muon.bluestop.org ([127.0.0.1]) by muon.bluestop.org (muon.bluestop.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vyR3zAhqRi59; Mon, 17 Jun 2019 13:09:23 -0600 (MDT) Received: from photon.int.bluestop.org (unknown [96.73.9.5]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by muon.bluestop.org (Postfix) with ESMTPSA; Mon, 17 Jun 2019 13:09:23 -0600 (MDT) Subject: Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId To: devel@edk2.groups.io, zhijux.fan@intel.com Cc: "Gao, Liming" , "Feng, Bob C" , "Zhang, Shenglei" , "Kinney, Michael D" References: From: rebecca@bluestop.org Openpgp: preference=signencrypt Autocrypt: addr=rebecca@bluestop.org; keydata= mQINBFrUMZ4BEADI1yUEGeZeXeTCPay1ZpTBdDEpGPAw1dq2VCSTc1VhsnrEBa1iZxAfaeSv Uu5Ti7jlhQ/3sQMl0bJMKGB/RtmIW7k8h2w476oZmG8gChk8su5ZEx/pV1gdqInyFmmJKTYc gabJz8pL+m82w07qPv+oalepZ4dbj+HF++RAK/iEju+q9UHlsjj8e3mMNsvtrOz1K6bnpveO jZ+ms/2H3Hs5a4k8y6buwe2RvwhJQaXa13cR3LhzL+nwj4B9PHZZEa2WpEyYpw/bI0V9YSQN QgC1CYRzDyakZge6BCM6wHOgZSUzRPufGilrNKUwIVbRoIBR9/85+0wR+PlFUOUOfOc6ox7T dWcIx6PuPhek48rh4uwmmwsPtPiH4Z3T5p+GmWQ9NLFZKA1YnEdaSkWtYZsDxwVZZeYG2plt MfhXP0Hj4rf9Y3eoUenCaGioxAbUOBCtXdTGNAhNjz1g5NGDBVyhjKkzwJQvt9UrYTseERit 5dX2CMTy8hYLvSXd/Ivy+HylUS5IslfZxW5z9LgWX7Z97kILgkH3N0ewtLkygkG+Y+x7uaAV dFqp9ASOyzaiwKbJdeOI+WxRSh+AqeCR0S+bpkcLudLmbjrPmaFwjKycy1H85Z5R2J3YHyXY oT6OYjD8vLbUU2GWp6Onkcy1Pu8EMbRuzKil6HnpYg3BexbPFwARAQABtCNSZWJlY2NhIENy YW4gPHJlYmVjY2FAYmx1ZXN0b3Aub3JnPokCVwQTAQgAQQIbIwUJCWYBgAULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBB+5fZtkTdO940Yr4g0CK1MRvhAgBQJa2B9zAhkBAAoJEA0CK1MR vhAgzJEQAJUqVmTRO9OqCSS2CVKjrqnEWJMvyo0K8B+WiXo0nSQg9+uyoVU7h2s/kkWVGy4u IWbGy2Qe8LiXzBJjHC3TadGvOvakfdMeKKXcgxgX6KlhA9hA2LW6tg22aHUk7Flr/8diHpgf qIwrXhqJXZmK72GR1QfhgoHsOsTJ9GWPswo1kUMc0cJowq0qP1RDdua6BwvDHHPJwu9OmC/i oQlMNm9gkBDq8H2B+m125ANwCnqBizXaiTTLQdewTMbCSuxbsni2icDqwBfFXzEgcJGaYYfB cQeFsfCmtXQK3JUd4Myx128Dxk9P3X64I93SB7QzB0nmWlyvmCFBNoCp0PCLA4qbwbw2sMRX Wx4BqYa8nI/jg+Nqo+Ut2BfltNZIlsHxK+XhxejfLqAjRCZeLnu1otvFnFuGLaAVYx9x1Y1q J8VizZxq6ujio62Qpultp6KNhlkJ+OKoGwA0k4NHh26SxvlsNxlfg/2v9b1LqWRzNujnwbcF 8g4902XjyBLxV+9YpXZEa8H6zzEHxpeDPWT3QfvrT8JuoHa1IyYnUKvG674UKW5zEGEwkQc9 cuQwR1RHd1ZrKtH1duXzaLr/caMp8ZDfGDDxFpenJTRxNRlg4+K7HSdhpac7sBVMUA8uVdE+ iuTThOmdf0c4DorL3BIh6Yv3FV4/NSqT1Wn3CG2fgG1guQINBFrUMZ4BEADkc4mvMcMcDF1t dNxNQuIBE1F243oZamG3LACCKfc1Yur3CPzHwIk5LXCUmbq23iE5bowxMWw3mlVT0p5xM0Wn UidIBwCKu4kRyy/fY4NyWWBuwy9srpTdmUcKRBRNB8zEZE8xIlidD1ijjgqLBfeM7n9ylawA xHLxwU96sdpdHFzb7Z0yKY2e/bzDaHiG0fUvcCmkgLf+uwKKZid1j8zR5PzKpgPqfy/PF01e KyGV3MNu8Y90xMoiEMWfCI2IB1m+hTuzZoboFvGV54SiMuvfWK/VMQjhsL6K2ddOqwVuy2nI MI4G3xDQW/v8KVyn43OSIAyW1eaklhzu0Ir2sO60PXRkvbTUrouvmSvpJfIQS49rU0M/X6FS DgXQLKrZ3my94+g8ptz9KoVml6s4OAwYVz+sb49nuSxipFKkU5FwhKOLmzbsBxCtytcUJoLm juJPJPDQue6YJiIXyc86GVY2pH3DjemKdbB4dSgqAJIp+lCzKSJzz7bgueh2Ox8vzx1tSxKj 7V8Nal+UTKKbkxPmMh+e20YZ4esAVifO3bS6IJP/aDnfagghB71vA7+aWGXPbjPlc2UHpCBi RSsl+IgoQXvdvZBsKRyfBx8neODa2C6JIE5vcaCjilSeKF8SzsFXvimnndhQNhAPU/DwQwSX dCl4gTsFVi5d8Oxq1sce+wARAQABiQI8BBgBCAAmFiEEH7l9m2RN073jRiviDQIrUxG+ECAF AlrUMZ4CGwwFCQlmAYAACgkQDQIrUxG+ECAWnRAAsmZX+KgNxW3v7R/76Tz4Wjmh4AGeE+Ji 3p5QsdTYny1B6vYBL9vCzPJ/AK8pgKMDRaweUP5eZQpfrdWC8Q7SNGgi4Q+97KEs+i2xZLQ+ WJb8a+WEEIc716u0y4ITiHfOgM5jWcFO4MXQATbJgv0drLLesa+LQCvZgPBqupt307EsCubQ s+Sxt+RVjf6rOUolp1GJXEQYwGsKklVd6yqLC8M1BSG53/WE5tSv5GzBZ8fp6EtmjT7leuid FtEvKYHQz4DqG9ELpHUF0X0UUCBK/MgXe3kCVLKE060UrJ4M6uPSx57rmVFA2MvwQR8M7GsW C5UsSM4PYwPWBhwxE7vcx0691YKAHT/5q8LxRVBdUyzPSprMhSQFttsBt+ygm6wRi3Pi3TuC EARNubPkQefyeC34yr40SAUCkOl3eWxSXPF4NfXFQb4AAzZSE5hv3qbDuwo3lrL0LqpIpEQP Az+JZ1QZ6mMFQ5/JD9Gukj54kZc0X8w3sQt0a8vyE/qrJg8vKgv2rCHrPc5MeDkEUEFiiJiC EDdkJtMyoRlU3S4NrnbyLOLEcHE8fGe3hStPX8hY62id2ecdQ5WZ7vLZW5SFeLarbUciuHIk VL6MHnUjbV7XlY50N7ebeFCIdlCWhdum2FJs/Ni+SSxbZC564vrokwlBBGSo6WTPQTa8IWx1 DtU= Message-ID: Date: Mon, 17 Jun 2019 13:05:27 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US On 2019-06-17 04:54, Fan, ZhijuX wrote: > GenBiosId is a tool to generate the BIOS ID binary file which uses > the data from the configuration file. > https://bugzilla.tianocore.org/show_bug.cgi?id=1846 pylama (https://github.com/klen/pylama) reports the following issues: bcran@photon:~/workspace/edk2/BaseTools/Source/Python/GenBiosId % pylama . GenBiosId.py:1:1: E266 too many leading '#' for block comment [pycodestyle] GenBiosId.py:19:1: E722 do not use bare 'except' [pycodestyle] GenBiosId.py:21:1: W0401 'from Common.BuildToolError import *' used; unable to detect undefined names [pyflakes] GenBiosId.py:22:1: W0401 'from Common.Misc import *' used; unable to detect undefined names [pyflakes] GenBiosId.py:23:1: W0401 'from Common.DataType import *' used; unable to detect undefined names [pyflakes] GenBiosId.py:24:1: W0611 'Common.BuildVersion.gBUILD_VERSION' imported but unused [pyflakes] GenBiosId.py:34:80: E501 line too long (82 > 79 characters) [pycodestyle] GenBiosId.py:38:17: E203 whitespace before ':' [pycodestyle] GenBiosId.py:38:28: E203 whitespace before ':' [pycodestyle] GenBiosId.py:38:43: E203 whitespace before ':' [pycodestyle] GenBiosId.py:39:17: E203 whitespace before ':' [pycodestyle] GenBiosId.py:39:28: E203 whitespace before ':' [pycodestyle] GenBiosId.py:39:43: E203 whitespace before ':' [pycodestyle] GenBiosId.py:40:17: E203 whitespace before ':' [pycodestyle] GenBiosId.py:40:21: E201 whitespace after '{' [pycodestyle] GenBiosId.py:40:29: E203 whitespace before ':' [pycodestyle] GenBiosId.py:40:44: E203 whitespace before ':' [pycodestyle] GenBiosId.py:41:17: E203 whitespace before ':' [pycodestyle] GenBiosId.py:41:28: E203 whitespace before ':' [pycodestyle] GenBiosId.py:41:43: E203 whitespace before ':' [pycodestyle] GenBiosId.py:41:44: E231 missing whitespace after ':' [pycodestyle] GenBiosId.py:42:20: E203 whitespace before ':' [pycodestyle] GenBiosId.py:42:31: E203 whitespace before ':' [pycodestyle] GenBiosId.py:42:50: E203 whitespace before ':' [pycodestyle] GenBiosId.py:43:20: E203 whitespace before ':' [pycodestyle] GenBiosId.py:43:31: E203 whitespace before ':' [pycodestyle] GenBiosId.py:43:48: E203 whitespace before ':' [pycodestyle] GenBiosId.py:49:80: E501 line too long (83 > 79 characters) [pycodestyle] GenBiosId.py:53:1: E302 expected 2 blank lines, found 1 [pycodestyle] GenBiosId.py:53:1: C901 'Main' is too complex (17) [mccabe] GenBiosId.py:55:80: E501 line too long (90 > 79 characters) [pycodestyle] GenBiosId.py:57:80: E501 line too long (81 > 79 characters) [pycodestyle] GenBiosId.py:59:80: E501 line too long (102 > 79 characters) [pycodestyle] GenBiosId.py:60:80: E501 line too long (97 > 79 characters) [pycodestyle] GenBiosId.py:61:80: E501 line too long (110 > 79 characters) [pycodestyle] GenBiosId.py:65:80: E501 line too long (86 > 79 characters) [pycodestyle] GenBiosId.py:65:28: E225 missing whitespace around operator [pycodestyle] GenBiosId.py:66:1: W0401 'OPTION_MISSING may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:68:1: W0401 'OPTION_MISSING may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:69:1: W0401 'FatalError may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:69:1: W0612 local variable 'X' is assigned to but never used [pyflakes] GenBiosId.py:75:80: E501 line too long (86 > 79 characters) [pycodestyle] GenBiosId.py:75:1: W0401 'FILE_NOT_FOUND may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:80:80: E501 line too long (93 > 79 characters) [pycodestyle] GenBiosId.py:80:1: W0401 'FORMAT_NOT_SUPPORTED may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:85:80: E501 line too long (93 > 79 characters) [pycodestyle] GenBiosId.py:85:1: W0401 'FORMAT_INVALID may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:88:80: E501 line too long (92 > 79 characters) [pycodestyle] GenBiosId.py:88:1: W0401 'FORMAT_INVALID may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:91:80: E501 line too long (101 > 79 characters) [pycodestyle] GenBiosId.py:91:1: W0401 'FORMAT_UNKNOWN_ERROR may be undefined, or defined from star imports: Common.BuildToolError, Common.DataType, Common.Misc' [pyflakes] GenBiosId.py:95:80: E501 line too long (173 > 79 characters) [pycodestyle] GenBiosId.py:96:80: E501 line too long (111 > 79 characters) [pycodestyle] GenBiosId.py:96:14: E127 continuation line over-indented for visual indent [pycodestyle] GenBiosId.py:114:1: E305 expected 2 blank lines after class or function definition, found 1 [pycodestyle] GenBiosId.py:116:5: E266 too many leading '#' for block comment [pycodestyle] GenBiosId.py:117:24: E701 multiple statements on one line (colon) [pycodestyle]