From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA87D1A1E86 for ; Thu, 27 Oct 2016 02:12:41 -0700 (PDT) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5FA828EB4A; Thu, 27 Oct 2016 09:12:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-24.phx2.redhat.com [10.3.116.24]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9R9Cddq016861; Thu, 27 Oct 2016 05:12:40 -0400 To: "Zeng, Star" , "Zhang, Chao B" References: <20161026190504.9888-1-lersek@redhat.com> <20161026190504.9888-41-lersek@redhat.com> <1c78a137-2d0f-8ac2-da58-945639f1102e@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB04831039593491@shsmsx102.ccr.corp.intel.com> Cc: edk2-devel-01 From: Laszlo Ersek Message-ID: Date: Thu, 27 Oct 2016 11:12:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB04831039593491@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 27 Oct 2016 09:12:41 +0000 (UTC) Subject: Re: [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 09:12:42 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 10/27/16 11:09, Zeng, Star wrote: > Oh, it is Reviewed-by: Star Zeng . :) Great, thanks! Laszlo > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, October 27, 2016 5:08 PM > To: Zeng, Star ; Zhang, Chao B > Cc: edk2-devel-01 > Subject: Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE() > > Star, Chao, > > On 10/26/16 21:04, Laszlo Ersek wrote: >> Cc: Chao Zhang >> Cc: Star Zeng >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c >> b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c >> index c4fbb649f1fd..792a1232aed9 100644 >> --- a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c >> +++ b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c >> @@ -421,7 +421,7 @@ AuthVariableLibInitialize ( >> AuthVarLibContextOut->StructVersion = AUTH_VAR_LIB_CONTEXT_OUT_STRUCT_VERSION; >> AuthVarLibContextOut->StructSize = sizeof (AUTH_VAR_LIB_CONTEXT_OUT); >> AuthVarLibContextOut->AuthVarEntry = mAuthVarEntry; >> - AuthVarLibContextOut->AuthVarEntryCount = sizeof (mAuthVarEntry) / >> sizeof (mAuthVarEntry[0]); >> + AuthVarLibContextOut->AuthVarEntryCount = ARRAY_SIZE >> + (mAuthVarEntry); >> mAuthVarAddressPointer[0] = (VOID **) &mPubKeyStore; >> mAuthVarAddressPointer[1] = (VOID **) &mCertDbStore; >> mAuthVarAddressPointer[2] = (VOID **) &mHashCtx; @@ -433,7 +433,7 >> @@ AuthVariableLibInitialize ( >> mAuthVarAddressPointer[8] = (VOID **) &(mAuthVarLibContextIn->CheckRemainingSpaceForConsistency), >> mAuthVarAddressPointer[9] = (VOID **) &(mAuthVarLibContextIn->AtRuntime), >> AuthVarLibContextOut->AddressPointer = mAuthVarAddressPointer; >> - AuthVarLibContextOut->AddressPointerCount = sizeof >> (mAuthVarAddressPointer) / sizeof (mAuthVarAddressPointer[0]); >> + AuthVarLibContextOut->AddressPointerCount = ARRAY_SIZE >> + (mAuthVarAddressPointer); >> >> return Status; >> } >> > > can one of you guys please review this patch? > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >