From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Mon, 29 Apr 2019 05:26:09 -0700 Received: by mail-wr1-f67.google.com with SMTP id l2so75916wrb.9 for ; Mon, 29 Apr 2019 05:26:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CuAwsYcTvfSeRa0+dBLNpy7rYo0RTQC0jEGDAfWwko4=; b=YTwn6587eiFJUwwQQdraRmHkcLo1bDaXA6PNy5dDNMDE5ArJ50qV21+od3N6CGJu3p zLJbtVqDmYiwAF7nWPIU8LqSABj62jUmRyIqz7GHX/0I0UoK/QNN6pXBxm32zEmSqIzB c0Trt0q/i5QTVX4g3jpHeBFJn4LkHVzMET2bR11TsxEVjPoYhhX+dNEjrx79cMKYi2oe X9cPObjF8c/numXrjBcDukc4j3QN6tuXo+OePkkhLq58uFFua/CVums3fGgDmFaOeW67 HxKDbK7udaf8aauRbtlfLJxK1ZyTWdSSdFVU8UxWMyX5Fv1iv2ywrtW2YWZ8Iyuzu5h+ /GdQ== X-Gm-Message-State: APjAAAUzjjS2ihG78CoRXoFBBTO6gPy0n8YcMwyho7S0q7N/iGr1YvXE xqVvZf6DGtACPYch+PBrn3D+Rw== X-Google-Smtp-Source: APXvYqxdNPVY+dmOoVQ53+UpQux/G1Rw7jdFIiyXlk7QaZY6qk8l9L66Vr/R0se3PFxwn+D0wU384w== X-Received: by 2002:adf:ec8f:: with SMTP id z15mr31264395wrn.61.1556540767324; Mon, 29 Apr 2019 05:26:07 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id z4sm13577078wmk.5.2019.04.29.05.26.06 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 05:26:06 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 04/16] ArmVirtPkg: build EnrollDefaultKeys.efi To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel References: <20190427005328.27005-1-lersek@redhat.com> <20190427005328.27005-5-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 29 Apr 2019 14:26:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190427005328.27005-5-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Having removed VALID_ARCHITECTURES from > "OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf", it now makes sense to > reflect the related platform DSC bits from OvmfPkg to ArmVirtPkg. > > Build "EnrollDefaultKeys.efi" as part of ArmVirtQemu and ArmVirtQemuKernel > (which are the ArmVirtPkg platforms that include SecureBootConfigDxe too). > > Cc: Ard Biesheuvel > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 82335541f964..1848d20531ab 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -46,16 +46,17 @@ [LibraryClasses.common] > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf > > # > # Ramdisk Requirements > # > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index d6ba3b6ae397..28c8fd551344 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -270,16 +270,17 @@ [Components.common] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > !if $(SECURE_BOOT_ENABLE) == TRUE > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf { > > NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf > } > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > + OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > !else > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 129780548e4a..2a83c7469424 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -254,16 +254,17 @@ [Components.common] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > !if $(SECURE_BOOT_ENABLE) == TRUE > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf { > > NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf > } > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf > + OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > !else > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { >