Re: [edk2-devel] [PATCH v2 06/10] OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF

["Laszlo Ersek" <lersek@redhat.com>]

On 05/27/19 05:03, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811
> 
> This commit will update the driver's INF file to:
> 
> A) Assign a new file GUID;
> B) Consume the PCDs duplicated in OvmfPkg DEC file;
> C) Remove the IntelFramework[Module]Pkg DEC file dependency.
> 
> Please note that a subsequent commit (final patch of the series) will:
> 
> Replace the use of VideoDxe in IntelFrameworkModulePkg with the one copied
> in OvmfPkg within DSC/FDF files.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
>  OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf b/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
> index 1526bc4cc2..1ed4020661 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
> @@ -4,7 +4,7 @@
>  # This driver by using Legacy Bios protocol service to support csm Video
>  # and produce Graphics Output Protocol.
>  #
> -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -14,7 +14,7 @@ [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = BiosVideoDxe
>    MODULE_UNI_FILE                = BiosVideoDxe.uni
> -  FILE_GUID                      = 0B04B2ED-861C-42cd-A22F-C3AAFACCB896
> +  FILE_GUID                      = 8669E6C9-842B-4B49-BCC3-32C96D244750
>    MODULE_TYPE                    = UEFI_DRIVER
>    VERSION_STRING                 = 1.0
>  
> @@ -38,9 +38,7 @@ [Sources]
>  [Packages]
>    MdePkg/MdePkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> -  IntelFrameworkPkg/IntelFrameworkPkg.dec
> -  IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> -
> +  OvmfPkg/OvmfPkg.dec
>  
>  [LibraryClasses]
>    MemoryAllocationLib
> @@ -70,9 +68,9 @@ [Protocols]
>    gEfiEdidOverrideProtocolGuid                  ## SOMETIMES_CONSUMES
>  
>  [Pcd]
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoSetTextVgaModeEnable  ## CONSUMES
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoCheckVbeEnable        ## CONSUMES
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoCheckVgaEnable        ## SOMETIMES_CONSUMES
> +  gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoSetTextVgaModeEnable                 ## CONSUMES
> +  gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVbeEnable                       ## CONSUMES
> +  gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVgaEnable                       ## SOMETIMES_CONSUMES
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution                 ## SOMETIMES_CONSUMES
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution                   ## SOMETIMES_CONSUMES
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>