From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 13 Jun 2019 07:10:49 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 17D9F308620F; Thu, 13 Jun 2019 14:10:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id C35D65ED2B; Thu, 13 Jun 2019 14:10:42 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 06/10] OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: David Woodhouse , Ray Ni , Jordan Justen , Ard Biesheuvel References: <20190527030350.11996-1-hao.a.wu@intel.com> <20190527030350.11996-7-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 13 Jun 2019 16:10:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190527030350.11996-7-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 13 Jun 2019 14:10:49 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the driver's INF file to: > > A) Assign a new file GUID; > B) Consume the PCDs duplicated in OvmfPkg DEC file; > C) Remove the IntelFramework[Module]Pkg DEC file dependency. > > Please note that a subsequent commit (final patch of the series) will: > > Replace the use of VideoDxe in IntelFrameworkModulePkg with the one copied > in OvmfPkg within DSC/FDF files. > > Cc: David Woodhouse > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Hao A Wu > --- > OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf b/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf > index 1526bc4cc2..1ed4020661 100644 > --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf > +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf > @@ -4,7 +4,7 @@ > # This driver by using Legacy Bios protocol service to support csm Video > # and produce Graphics Output Protocol. > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -14,7 +14,7 @@ [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = BiosVideoDxe > MODULE_UNI_FILE = BiosVideoDxe.uni > - FILE_GUID = 0B04B2ED-861C-42cd-A22F-C3AAFACCB896 > + FILE_GUID = 8669E6C9-842B-4B49-BCC3-32C96D244750 > MODULE_TYPE = UEFI_DRIVER > VERSION_STRING = 1.0 > > @@ -38,9 +38,7 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > - IntelFrameworkPkg/IntelFrameworkPkg.dec > - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > - > + OvmfPkg/OvmfPkg.dec > > [LibraryClasses] > MemoryAllocationLib > @@ -70,9 +68,9 @@ [Protocols] > gEfiEdidOverrideProtocolGuid ## SOMETIMES_CONSUMES > > [Pcd] > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoSetTextVgaModeEnable ## CONSUMES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoCheckVbeEnable ## CONSUMES > - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdBiosVideoCheckVgaEnable ## SOMETIMES_CONSUMES > + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoSetTextVgaModeEnable ## CONSUMES > + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVbeEnable ## CONSUMES > + gUefiOvmfPkgTokenSpaceGuid.PcdBiosVideoCheckVgaEnable ## SOMETIMES_CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution ## SOMETIMES_CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution ## SOMETIMES_CONSUMES > > Reviewed-by: Laszlo Ersek