public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Wenyi Xie <xiewenyi2@huawei.com>,
	devel@edk2.groups.io, jordan.l.justen@intel.com, afish@apple.com,
	ray.ni@intel.com
Cc: songdongkuang@huawei.com
Subject: Re: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
Date: Fri, 11 Sep 2020 09:03:06 +0200	[thread overview]
Message-ID: <f07ee115-f9bd-b44e-252f-2ea2358403df@redhat.com> (raw)
In-Reply-To: <1599788966-78918-2-git-send-email-xiewenyi2@huawei.com>

On 09/11/20 03:49, Wenyi Xie wrote:
> edk2 DEC specification document only knows about DEC_SPECIFICATION,
> so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> correct.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  EmulatorPkg/EmulatorPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> index 90a8d2a8681a..064f963c72c6 100644
> --- a/EmulatorPkg/EmulatorPkg.dec
> +++ b/EmulatorPkg/EmulatorPkg.dec
> @@ -11,7 +11,7 @@
>  ##
>  
>  [Defines]
> -  DEC_VERSION                    = 0x00010005
> +  DEC_SPECIFICATION              = 0x00010005
>    PACKAGE_NAME                   = EmulatorPkg
>    PACKAGE_GUID                   = 36E48BD7-7D92-5A47-A2CD-513F072E3300
>    PACKAGE_VERSION                = 0.1
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


      parent reply	other threads:[~2020-09-11  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  1:49 [PATCH EDK2 v1 0/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION wenyi,xie
2020-09-11  1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2020-09-11  2:18   ` Ni, Ray
2020-09-14  2:57     ` 回复: [edk2-devel] " gaoliming
2020-09-11  7:03   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07ee115-f9bd-b44e-252f-2ea2358403df@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox