From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2813.1599807796815172371 for ; Fri, 11 Sep 2020 00:03:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JFJfKKvu; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599807796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P95r8ECfmbaOEVlI7w5BzNfBV3zJzFSx0aPFvWtbPuM=; b=JFJfKKvucXJV4MXjG7R240Hxh4hZhttN5cM44JmENsju041aZOxG6JF21vAIoZsE/9AGN5 +PWwykQjSFZW7CDlC5c7SVMG0TRLtAhDzuN+qtYrjWuCXmGEdjxB0lOsWC+HhmbeLfg1Ib VJb8jQUBBtYluBm4aLCmDAgR18XmyLc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-W5RU5ZbaMn295u9ek13QXw-1; Fri, 11 Sep 2020 03:03:12 -0400 X-MC-Unique: W5RU5ZbaMn295u9ek13QXw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FE2818B9EDF; Fri, 11 Sep 2020 07:03:10 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-52.ams2.redhat.com [10.36.113.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08B0F81C4C; Fri, 11 Sep 2020 07:03:07 +0000 (UTC) Subject: Re: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION To: Wenyi Xie , devel@edk2.groups.io, jordan.l.justen@intel.com, afish@apple.com, ray.ni@intel.com Cc: songdongkuang@huawei.com References: <1599788966-78918-1-git-send-email-xiewenyi2@huawei.com> <1599788966-78918-2-git-send-email-xiewenyi2@huawei.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 11 Sep 2020 09:03:06 +0200 MIME-Version: 1.0 In-Reply-To: <1599788966-78918-2-git-send-email-xiewenyi2@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 09/11/20 03:49, Wenyi Xie wrote: > edk2 DEC specification document only knows about DEC_SPECIFICATION, > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not > correct. > > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Wenyi Xie > --- > EmulatorPkg/EmulatorPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec > index 90a8d2a8681a..064f963c72c6 100644 > --- a/EmulatorPkg/EmulatorPkg.dec > +++ b/EmulatorPkg/EmulatorPkg.dec > @@ -11,7 +11,7 @@ > ## > > [Defines] > - DEC_VERSION = 0x00010005 > + DEC_SPECIFICATION = 0x00010005 > PACKAGE_NAME = EmulatorPkg > PACKAGE_GUID = 36E48BD7-7D92-5A47-A2CD-513F072E3300 > PACKAGE_VERSION = 0.1 > Reviewed-by: Laszlo Ersek