From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 891997803D0 for ; Fri, 3 May 2024 16:58:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1BR1V2CNRLRoM+mulAOB/gKvSiYi8ByOkGNbXJGLJCY=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714755488; v=1; b=Ua50YY8N3eUi/ngb6tOLz97glRcu9ouwxje5fiqX6sL8Vaw+TFEXdidVFo/HnlrCG2A7m+cg XZQx7UYKGv6prvdSVxhO1UYctLPHXQILT4whMYtYuvzgK2+oM9/nW81FFPJoocRULAms2qOVv5r r8sBQ9AxskjNzlmTPM856jTlOuj8ZZlSloWgdUcLBCslD9eU3cr6UggtLht8zSbsL6l++2dnSOh 90sPN/QElNIT34BnSzaiqQBWbZeaCGX2yqlJvdw4BMaN3hcG84fveaEK9bEd7yqmZd57Gfye1BW fPaJNo1/8NXEwT3jltICt6929qIzFYYwRhIhhOlKennqA== X-Received: by 127.0.0.2 with SMTP id bC26YY7687511xZxAMHtUyzP; Fri, 03 May 2024 09:58:08 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.18630.1714755487460275204 for ; Fri, 03 May 2024 09:58:07 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.8]) by linux.microsoft.com (Postfix) with ESMTPSA id 1DE04207DBBD; Fri, 3 May 2024 09:58:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1DE04207DBBD Message-ID: Date: Fri, 3 May 2024 09:58:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: "Kinney, Michael D" , Leif Lindholm , "devel@edk2.groups.io" , "rfc@edk2.groups.io" Cc: "Andrew Fish (afish@apple.com)" References: <5116382f-a1cf-46fc-95a2-58c7f810765d@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 03 May 2024 09:58:07 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EuVbxAKe1RWOM1sq1NtKFC9Ix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Ua50YY8N; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/2/2024 12:37 PM, Kinney, Michael D wrote: >=20 >=20 >> -----Original Message----- >> From: Leif Lindholm >> Sent: Thursday, May 2, 2024 3:57 AM >> To: devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney, Michael >> D ; rfc@edk2.groups.io >> Cc: Andrew Fish (afish@apple.com) >> Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from >> email to GitHub Pull Requests on 5-24-2024 >> >> On 2024-05-02 04:08, Michael Kubacki wrote: >>> Thank you for this proposal. We've been anticipating this change for >>> years and are excited to help support it. >>> >>> Here's some items we'd like to raise for feedback that we could help >>> implement. Many could likely be done in time for the transition. >>> >>> 1. Automate reviewers - We've discussed CODEOWNERS in the past. >> However, >>> a simpler approach (in maintaining/syncing less files) would be to use >>> Maintainers.txt directly with a GitHub workflow since the file already >>> contains GitHub IDs. >> >> That would be ideal. I know Mike worked on autogenerating CODEOWNERS >> from Maintainers.txt, but ultimately the latter supports more flexible >> use of wildcards (things like */AArch64/ currently requires reconciling >> against the repo contents). >=20 > I have a python script that can verify if there are any differences > Between CODEOWNERS and Maintainers.txt. I do not any tools that can > convert Maintainers.txt to CODEOWNERS. That has been a manual process. >=20 > I recommend we identify a plan to switch to CODEOWNERS and drop > Maintainers.txt. May take a while for everyone to get used to the > differences. >=20 I agree it would be nice to switch to CODEOWNERS to reuse the native=20 functionality built into GitHub for it. We could build upon that if=20 necessary. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118558): https://edk2.groups.io/g/devel/message/118558 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-