From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web12.1711.1654196925218703596 for ; Thu, 02 Jun 2022 12:08:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=V+49j5do; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252IC25k030879; Thu, 2 Jun 2022 19:08:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=vnzPhJl/k58/yFt4EUZFyExSxstHU2NFFtE4RvUSBio=; b=V+49j5doz/3d9zitTgt8LQ6j700p7zhgK9++U/suZ+P+tOVTNnHfsIQF9XIXxtKNttz1 MHNvIP+BJYgkHkjmcIRqajthNcvgUAQCwZvdG7IGX3KLkiOy0pT908HXKFvqBbvtLQWk aMpm1fMVGx7I8Y8GX1+02/ayLdU1QBhfPznT04lNmmRDmADGH7/L76o38GSiEzFoIAdN yR70wtiaJUVLsngdWucFlphQjsfC6sR4mTwzgRT5nmWYQcZcb2I+d4BYW8kucyIJEcQk 7Vqw/lmudP+qgtoreJ4dhs0ZNQ2woCBFI+5qv3dZkz5l8gBTYAtTznXRgQk6yynQX+ee dQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gf296ru64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 19:08:43 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 252IZ3xI012013; Thu, 2 Jun 2022 19:08:43 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gf296ru5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 19:08:42 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 252J63ph011113; Thu, 2 Jun 2022 19:08:41 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma01dal.us.ibm.com with ESMTP id 3gcxt5vke1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 19:08:41 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 252J8eo326870132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Jun 2022 19:08:40 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BAA5828059; Thu, 2 Jun 2022 19:08:40 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37FAF2805C; Thu, 2 Jun 2022 19:08:38 +0000 (GMT) Received: from [9.65.229.167] (unknown [9.65.229.167]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 2 Jun 2022 19:08:38 +0000 (GMT) Message-ID: Date: Thu, 2 Jun 2022 22:08:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/1] OvmfPkg/AmdSev: remove unused SMM bits from .dsc and .fdf files To: Gerd Hoffmann , devel@edk2.groups.io Cc: James Bottomley , Min Xu , Jiewen Yao , Oliver Steffen , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Pawel Polawski , Tom Lendacky , Brijesh Singh , Dov Murik References: <20220602091105.376777-1-kraxel@redhat.com> From: "Dov Murik" In-Reply-To: <20220602091105.376777-1-kraxel@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dk7PUC8nqdy6sx6GQUrDse-PKbDgstrk X-Proofpoint-ORIG-GUID: trB6soZ7lTYL71xHThFKUXHOGFW51L0d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-02_05,2022-06-02_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206020081 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Gerd, thanks for the cleanup. Tested-by: Dov Murik Reviewed-by: Dov Murik On 02/06/2022 12:11, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 47 ------------------------------------ > OvmfPkg/AmdSev/AmdSevX64.fdf | 15 ------------ > 2 files changed, 62 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index fc1fdb2e2297..6b3827f7f6ed 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -93,14 +93,6 @@ [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > XCODE:*_*_*_MTOC_FLAGS = -align 0x1000 > CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096 > > -# Force PE/COFF sections to be aligned at 4KB boundaries to support page level > -# protection of DXE_SMM_DRIVER/SMM_CORE modules > -[BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE] > - GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > - XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000 > - XCODE:*_*_*_MTOC_FLAGS = -align 0x1000 > - CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096 > - > ################################################################################ > # > # SKU Identification section - list of all SKU IDs supported by this Platform. > @@ -380,45 +372,6 @@ [LibraryClasses.common.UEFI_APPLICATION] > !endif > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > > -[LibraryClasses.common.DXE_SMM_DRIVER] > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - TimerLib|OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > - ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > - MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf > - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > - MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > - SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > -!ifdef $(DEBUG_ON_SERIAL_PORT) > - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > -!else > - DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > -!endif > - CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf > -!if $(SOURCE_DEBUG_ENABLE) == TRUE > - DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > -!endif > - BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > - PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > - > -[LibraryClasses.common.SMM_CORE] > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - TimerLib|OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > - ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > - SmmCorePlatformHookLib|MdeModulePkg/Library/SmmCorePlatformHookLibNull/SmmCorePlatformHookLibNull.inf > - MemoryAllocationLib|MdeModulePkg/Library/PiSmmCoreMemoryAllocationLib/PiSmmCoreMemoryAllocationLib.inf > - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > - SmmServicesTableLib|MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmServicesTableLib.inf > -!ifdef $(DEBUG_ON_SERIAL_PORT) > - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > -!else > - DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > -!endif > - PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > - > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform. > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf > index 844ba8a116d8..4658e1d30ed0 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -436,18 +436,3 @@ [Rule.Common.SEC.RESET_VECTOR] > FILE RAW = $(NAMED_GUID) { > RAW BIN Align = 16 |.bin > } > - > -[Rule.Common.SMM_CORE] > - FILE SMM_CORE = $(NAMED_GUID) { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > - } > - > -[Rule.Common.DXE_SMM_DRIVER] > - FILE SMM = $(NAMED_GUID) { > - SMM_DEPEX SMM_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > - }