From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
edk2-devel@lists.01.org
Subject: Re: [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code
Date: Tue, 25 Sep 2018 13:03:51 +0800 [thread overview]
Message-ID: <f0c84360-1d5d-9798-2165-f6674429773f@Intel.com> (raw)
In-Reply-To: <222e8a1a-72c9-e125-66c1-05737ba6a360@intel.com>
On 9/25/2018 11:13 AM, Zeng, Star wrote:
> On 2018/9/25 10:47, Ni, Ruiyu wrote:
>
> But then there will be a little inconsistent, for example OPERATION_TYPE
> is only used by PciRootBridgeIo.c.
Since coding style document doesn't define clear rule for this (I also
don't like a coding style document with so many detailed restrictions.
This removes the fun from coding.), I agree there is inconsistency.
>
>
>>
>> I agree moving mIoMmuProtocol to PciHostBridge.h.
>> I am happy to do that in a separate patch in V2.
>
> Thanks. If we will only move mIoMmuProtocol, it can be in a separated
> patch.
>
>
> Star
>
>>
>> Agree?
>>
>>>
>>> Thanks,
>>> Star
>>>
>>>>
>>>> With or without changes:
>>>>
>>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>>
>>>> Thanks
>>>> Laszlo
>>>>
>>>
>>
>>
>
--
Thanks,
Ray
next prev parent reply other threads:[~2018-09-25 5:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 7:25 [PATCH 0/3] Fix a bug that prevents PMEM access Ruiyu Ni
2018-09-21 7:25 ` [PATCH 1/3] MdeModulePkg/PciHostBridge: Enhance boundary check in Io/Mem.Read/Write Ruiyu Ni
2018-09-21 10:53 ` Laszlo Ersek
2018-09-24 13:18 ` Kirkendall, Garrett
2018-09-25 2:14 ` Zeng, Star
2018-09-25 2:43 ` Ni, Ruiyu
2018-09-25 3:02 ` Zeng, Star
2018-09-21 7:25 ` [PATCH 2/3] MdeModulePkg/PciHostBridge: Fix a bug that prevents PMEM access Ruiyu Ni
2018-09-21 11:06 ` Laszlo Ersek
2018-09-25 2:11 ` Ni, Ruiyu
2018-09-24 13:19 ` Kirkendall, Garrett
2018-09-25 2:15 ` Zeng, Star
2018-09-21 7:25 ` [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code Ruiyu Ni
2018-09-21 11:12 ` Laszlo Ersek
2018-09-25 2:25 ` Ni, Ruiyu
2018-09-25 2:35 ` Zeng, Star
2018-09-25 2:47 ` Ni, Ruiyu
2018-09-25 3:13 ` Zeng, Star
2018-09-25 5:03 ` Ni, Ruiyu [this message]
2018-09-24 13:20 ` Kirkendall, Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c84360-1d5d-9798-2165-f6674429773f@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox