From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF12421155D24 for ; Mon, 24 Sep 2018 22:03:01 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 22:03:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,300,1534834800"; d="scan'208";a="75936374" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.8]) ([10.239.9.8]) by orsmga008.jf.intel.com with ESMTP; 24 Sep 2018 22:02:55 -0700 To: "Zeng, Star" , Laszlo Ersek , edk2-devel@lists.01.org References: <20180921072539.268068-1-ruiyu.ni@intel.com> <20180921072539.268068-4-ruiyu.ni@intel.com> <12daedaa-952f-fc73-3ed5-62970f869ba9@redhat.com> <976f49ab-75e4-2009-ec78-e73a52212552@intel.com> <222e8a1a-72c9-e125-66c1-05737ba6a360@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Tue, 25 Sep 2018 13:03:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <222e8a1a-72c9-e125-66c1-05737ba6a360@intel.com> Subject: Re: [PATCH 3/3] MdeModulePkg/PciHostBridge: Add RESOURCE_VALID() to simplify code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 05:03:01 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/25/2018 11:13 AM, Zeng, Star wrote: > On 2018/9/25 10:47, Ni, Ruiyu wrote: > > But then there will be a little inconsistent, for example OPERATION_TYPE > is only used by PciRootBridgeIo.c. Since coding style document doesn't define clear rule for this (I also don't like a coding style document with so many detailed restrictions. This removes the fun from coding.), I agree there is inconsistency. > > >> >> I agree moving mIoMmuProtocol to PciHostBridge.h. >> I am happy to do that in a separate patch in V2. > > Thanks. If we will only move mIoMmuProtocol, it can be in a separated > patch. > > > Star > >> >> Agree? >> >>> >>> Thanks, >>> Star >>> >>>> >>>> With or without changes: >>>> >>>> Reviewed-by: Laszlo Ersek >>>> >>>> Thanks >>>> Laszlo >>>> >>> >> >> > -- Thanks, Ray