From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines
Date: Fri, 17 Apr 2020 18:01:24 +0200 [thread overview]
Message-ID: <f0d3db9b-c638-ade2-f89a-8b893cc76f4c@redhat.com> (raw)
In-Reply-To: <20200417153751.7110-2-lersek@redhat.com>
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
> Wrap the source code and the INF file at 79 characters.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 3 ++-
> OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 20 +++++++++++---------
> 2 files changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> index 2f24dac87faf..063dc49f2453 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> @@ -15,7 +15,8 @@ [Defines]
> LIBRARY_CLASS = ResetSystemLib
>
> #
> -# The following information is for reference only and not required by the build tools.
> +# The following information is for reference only and not required by the build
> +# tools.
> #
> # VALID_ARCHITECTURES = IA32 X64
> #
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 2f2e1293a3ef..b3abda80e75a 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -103,10 +103,11 @@ ResetShutdown (
>
> /**
> This function causes a systemwide reset. The exact type of the reset is
> - defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> - into ResetData. If the platform does not recognize the EFI_GUID in ResetData
> - the platform must pick a supported reset type to perform.The platform may
> - optionally log the parameters from any non-normal reset that occurs.
> + defined by the EFI_GUID that follows the Null-terminated Unicode string
> + passed into ResetData. If the platform does not recognize the EFI_GUID in
> + ResetData the platform must pick a supported reset type to perform.The
> + platform may optionally log the parameters from any non-normal reset that
> + occurs.
>
> @param[in] DataSize The size, in bytes, of ResetData.
> @param[in] ResetData The data buffer starts with a Null-terminated string,
> @@ -128,11 +129,12 @@ ResetPlatformSpecific (
> @param[in] ResetType The type of reset to perform.
> @param[in] ResetStatus The status code for the reset.
> @param[in] DataSize The size, in bytes, of ResetData.
> - @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or EfiResetShutdown
> - the data buffer starts with a Null-terminated string, optionally
> - followed by additional binary data. The string is a description
> - that the caller may use to further indicate the reason for the
> - system reset.
> + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, or
> + EfiResetShutdown the data buffer starts with a
> + Null-terminated string, optionally followed by
> + additional binary data. The string is a description
> + that the caller may use to further indicate the
> + reason for the system reset.
> **/
> VOID
> EFIAPI
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2020-04-17 16:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:37 [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix Laszlo Ersek
2020-04-17 15:37 ` [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines Laszlo Ersek
2020-04-17 16:01 ` Philippe Mathieu-Daudé [this message]
2020-04-17 15:37 ` [PATCH 2/6] OvmfPkg/ResetSystemLib: clean up library dependencies Laszlo Ersek
2020-04-17 16:02 ` Philippe Mathieu-Daudé
2020-04-17 15:37 ` [PATCH 3/6] OvmfPkg/ResetSystemLib: improve coding style in ResetSystem() Laszlo Ersek
2020-04-17 16:02 ` Philippe Mathieu-Daudé
2020-04-17 15:37 ` [PATCH 4/6] OvmfPkg/ResetSystemLib: factor out ResetShutdown() Laszlo Ersek
2020-04-17 16:05 ` Philippe Mathieu-Daudé
2020-04-17 15:37 ` [PATCH 5/6] OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib Laszlo Ersek
2020-04-21 17:27 ` [edk2-devel] " Laszlo Ersek
2020-04-21 18:08 ` Philippe Mathieu-Daudé
2020-04-17 15:37 ` [PATCH 6/6] OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib instance Laszlo Ersek
2020-04-17 16:23 ` Philippe Mathieu-Daudé
2020-04-17 15:59 ` [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix Ard Biesheuvel
2020-04-17 16:19 ` Philippe Mathieu-Daudé
2020-04-20 9:48 ` Laszlo Ersek
2020-04-20 10:17 ` Philippe Mathieu-Daudé
2020-04-20 9:46 ` Laszlo Ersek
2020-04-21 17:49 ` Rebecca Cran
2020-04-22 20:35 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d3db9b-c638-ade2-f89a-8b893cc76f4c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox