From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.54.1587139292104382034 for ; Fri, 17 Apr 2020 09:01:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bMwP5ldR; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587139291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0JbC6VGqRFfH0T0lDGjDpjPXdbY9eZD3FFlFU99zvBY=; b=bMwP5ldRBXb8FwzBMqWK7TY/C/CN9bWPkCHhNPb2ayK7Qeh7ZfriGd3xo3qLT8FqdJ3DPH IxNi122s2X9wbtKwGlWg2Phntw5N0otTatIpGtAWviwiX0WWI9fKJTLxdHLu1+gZkP40dG d7mixT029bscQMCtf8EnbgXc0mq5VaI= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-74-GUtfhA8KPhS0xqZ2f6-KeQ-1; Fri, 17 Apr 2020 12:01:29 -0400 X-MC-Unique: GUtfhA8KPhS0xqZ2f6-KeQ-1 Received: by mail-ej1-f71.google.com with SMTP id m21so1236173ejd.17 for ; Fri, 17 Apr 2020 09:01:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eYWse7YMBdDOS+RtRmqU0kuS+xTIDt609FjTqPZ2Jq0=; b=ahJpgqKvxB95hJ6ttDxZ9bXuq6z18ocT9V2GwEN0EbjwkQTav4kuC6ZDaxGzeK5kb3 a+l2kqw746O5XbywAYD8kpaJ7p9yNBA8JvANaJ4W8kbKbCvj2d1GhgeoHwQue4fhIWkp piiYJaW3j1GwtrDGjjY2nUS2R9XepD+H2S2Fri9meSnMEeztlUXIngauIbic5EpZOjGr NlDBCKq/IYUJc+5vx8K+Ho8bXxe0IcCKOVgTXNb0NwGX7u1S1kypZpsIj2CXOiOUVH80 brOzR0of1JHdAbEhtB6WnAEVj4uR2y40h8Sk8JpV1PbK7WuyKUNp+U09M2/w5oSMI2vt k1IQ== X-Gm-Message-State: AGi0PuavxPcsbctstR8cz+qeIUEg2nGUA83yYZOdMZVoLBWbTvXjvZku +WpTgpi49+eWe2wcP5lqLUT/jr9iqnibESy3H6UiTT9qEoJ5Z5FhB9goTebb6akV7GwqxXwommf lCAz2voTvfRhS1g== X-Received: by 2002:a17:906:130e:: with SMTP id w14mr3806431ejb.155.1587139288183; Fri, 17 Apr 2020 09:01:28 -0700 (PDT) X-Google-Smtp-Source: APiQypLYqwweULVOzdRMLqulTdjHX2/3ZYppjQConhiAjEFgktPxOC1eM2VMI68XFRooqlvQJ4jLIw== X-Received: by 2002:a17:906:130e:: with SMTP id w14mr3806379ejb.155.1587139287688; Fri, 17 Apr 2020 09:01:27 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id jx1sm1508743ejb.87.2020.04.17.09.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2020 09:01:25 -0700 (PDT) Subject: Re: [PATCH 1/6] OvmfPkg/ResetSystemLib: wrap long lines To: Laszlo Ersek , edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , Rebecca Cran References: <20200417153751.7110-1-lersek@redhat.com> <20200417153751.7110-2-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 17 Apr 2020 18:01:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200417153751.7110-2-lersek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/17/20 5:37 PM, Laszlo Ersek wrote: > Wrap the source code and the INF file at 79 characters. >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2675 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 3 ++- > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 20 +++++++++++-----= ---- > 2 files changed, 13 insertions(+), 10 deletions(-) >=20 > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/= Library/ResetSystemLib/ResetSystemLib.inf > index 2f24dac87faf..063dc49f2453 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > @@ -15,7 +15,8 @@ [Defines] > LIBRARY_CLASS =3D ResetSystemLib > =20 > # > -# The following information is for reference only and not required by th= e build tools. > +# The following information is for reference only and not required by th= e build > +# tools. > # > # VALID_ARCHITECTURES =3D IA32 X64 > # > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Li= brary/ResetSystemLib/ResetSystemLib.c > index 2f2e1293a3ef..b3abda80e75a 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > @@ -103,10 +103,11 @@ ResetShutdown ( > =20 > /** > This function causes a systemwide reset. The exact type of the reset = is > - defined by the EFI_GUID that follows the Null-terminated Unicode strin= g passed > - into ResetData. If the platform does not recognize the EFI_GUID in Res= etData > - the platform must pick a supported reset type to perform.The platform = may > - optionally log the parameters from any non-normal reset that occurs. > + defined by the EFI_GUID that follows the Null-terminated Unicode strin= g > + passed into ResetData. If the platform does not recognize the EFI_GUID= in > + ResetData the platform must pick a supported reset type to perform.The > + platform may optionally log the parameters from any non-normal reset t= hat > + occurs. > =20 > @param[in] DataSize The size, in bytes, of ResetData. > @param[in] ResetData The data buffer starts with a Null-terminated = string, > @@ -128,11 +129,12 @@ ResetPlatformSpecific ( > @param[in] ResetType The type of reset to perform. > @param[in] ResetStatus The status code for the reset. > @param[in] DataSize The size, in bytes, of ResetData. > - @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, or EfiResetShutdown > - the data buffer starts with a Null-terminate= d string, optionally > - followed by additional binary data. The stri= ng is a description > - that the caller may use to further indicate = the reason for the > - system reset. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, or > + EfiResetShutdown the data buffer starts with= a > + Null-terminated string, optionally followed = by > + additional binary data. The string is a desc= ription > + that the caller may use to further indicate = the > + reason for the system reset. > **/ > VOID > EFIAPI >=20 Reviewed-by: Philippe Mathieu-Daude