From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 07:05:05 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9804B83F4C; Tue, 30 Jul 2019 14:05:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F4F560BE5; Tue, 30 Jul 2019 14:05:03 +0000 (UTC) Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code To: shenglei , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20190730064007.13212-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 30 Jul 2019 16:05:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190730064007.13212-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 30 Jul 2019 14:05:04 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/30/19 08:40, shenglei wrote: > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index ef16997547..990dfe6826 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1398,7 +1398,7 @@ InternalSmmStartupAllAPs ( > > Wrapper for Procedures. > > - @param[in] Buffer Pointer to PROCEDURE_WRAPPER buffer. > + @param[in,out] Buffer Pointer to PROCEDURE_WRAPPER buffer. > > **/ > EFI_STATUS > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index 186809f431..c73f13e3c8 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1295,7 +1295,7 @@ RestoreCr2 ( > @param[in] Procedure The address of the procedure to run > @param[in] CpuIndex Target CPU Index > @param[in,out] ProcArguments The parameter to pass to the procedure > - @param[in,out] Token This is an optional parameter that allows the caller to execute the > + @param[in] Token This is an optional parameter that allows the caller to execute the > procedure in a blocking or non-blocking fashion. If it is NULL the > call is blocking, and the call will not return until the AP has > completed the procedure. If the token is not NULL, the call will > @@ -1387,7 +1387,7 @@ IsPresentAp ( > @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for > APs to return from Procedure, either for > blocking or non-blocking mode. > - @param[in,out] ProcedureArgument The parameter passed into Procedure for > + @param[in,out] ProcedureArguments The parameter passed into Procedure for > all APs. > @param[in,out] Token This is an optional parameter that allows the caller to execute the > procedure in a blocking or non-blocking fashion. If it is NULL the > I'll let Eric and Ray check this, as the patch only modifies comments. Thanks Laszlo