Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

["Taylor Beebe" <taylor.d.beebe@gmail.com>]

Hey Nate,

I'm about to send out a series to add the library across the repo -- 
just having some smtp authentication issues :D

Are you updating all the packages or just a subset?

-Taylor

On 11/30/2023 4:18 PM, Nate DeSimone wrote:
> Commit 7284c44 in edk2 introduces an incompatibility that causes any
> project that uses DxeMain.inf to fail to build. This is due to the
> addition of ImagePropertiesRecordLib, and a new added dependency on
> that library in DxeMain. Platforms will not have this LibraryClass
> defined in their DSC yet and hence currently fail to build.
>
> This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg
> and resolves the build failure.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>   Platform/Intel/QuarkPlatformPkg/Quark.dsc    | 1 +
>   Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index 7cc548058a..40d9768336 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -196,6 +196,7 @@
>   !endif
>   
>     FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     #
>     # CPU
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index 59577eda4f..67472930c9 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -167,6 +167,7 @@
>   !endif
>   
>     CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     #
>     # CPU


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111929): https://edk2.groups.io/g/devel/message/111929
Mute This Topic: https://groups.io/mt/102906246/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-