From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6D167740035 for ; Fri, 1 Dec 2023 00:21:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LbniKB5XQ0iD7l1fLYclU7lxRW64B5LScUjDxMKUZqE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701390106; v=1; b=BbmdYYEJttLzqAJJn6bC8pW3A2NmxIhdQiFdEVYpjYRIqDw1fupjwAVQv2kjxmXslvrLbXfB 3z3IrQYq5wGucJ8h99WSs+qyr+QfFE16FL06xk6VG9emvsua1CIje7RZ/4X9ue2fNtUUzapzQ5X uOyIEm20edYwvJG/qO+/dONc= X-Received: by 127.0.0.2 with SMTP id bMW7YY7687511xbOZmMoqo0m; Thu, 30 Nov 2023 16:21:46 -0800 X-Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mx.groups.io with SMTP id smtpd.web10.11578.1701390105602487610 for ; Thu, 30 Nov 2023 16:21:45 -0800 X-Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6cde4aeea29so1320615b3a.2 for ; Thu, 30 Nov 2023 16:21:45 -0800 (PST) X-Gm-Message-State: uVXWl8Pk0qImvbD7hbJBBfOgx7686176AA= X-Google-Smtp-Source: AGHT+IGp7hbh8pvZU3jA7eQtpqrrvFONc8w/Jpn63cPqrkVKfWlQv09oYE3/iG1NaJN4y4UiEnL91w== X-Received: by 2002:a05:6a20:4413:b0:18a:d5a6:7e14 with SMTP id ce19-20020a056a20441300b0018ad5a67e14mr26262484pzb.56.1701390104781; Thu, 30 Nov 2023 16:21:44 -0800 (PST) X-Received: from [192.168.0.125] ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id hq23-20020a056a00681700b006cddd9d0174sm1800290pfb.108.2023.11.30.16.21.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 16:21:44 -0800 (PST) Message-ID: Date: Thu, 30 Nov 2023 16:21:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures To: Nate DeSimone , devel@edk2.groups.io Cc: Chasel Chiu , Ray Ni , Sai Chaganty , Liming Gao , Michael D Kinney , Kelly Steele , Michael Kubacki References: <20231201001822.3346-1-nathaniel.l.desimone@intel.com> From: "Taylor Beebe" In-Reply-To: <20231201001822.3346-1-nathaniel.l.desimone@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BbmdYYEJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hey Nate, I'm about to send out a series to add the library across the repo --=20 just having some smtp authentication issues :D Are you updating all the packages or just a subset? -Taylor On 11/30/2023 4:18 PM, Nate DeSimone wrote: > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg > and resolves the build failure. > > Cc: Chasel Chiu > Cc: Ray Ni > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Taylor Beebe > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/Q= uarkPlatformPkg/Quark.dsc > index 7cc548058a..40d9768336 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -196,6 +196,7 @@ > !endif > =20 > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.= inf > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > =20 > # > # CPU > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Inte= l/QuarkPlatformPkg/QuarkMin.dsc > index 59577eda4f..67472930c9 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -167,6 +167,7 @@ > !endif > =20 > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.i= nf > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > =20 > # > # CPU -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111929): https://edk2.groups.io/g/devel/message/111929 Mute This Topic: https://groups.io/mt/102906246/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-