From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AB3CF94133E for ; Thu, 29 Feb 2024 07:43:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6coRv3mNFLB65b4h27ZvKErqlsPdSGCNdvtScA5swrM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709192590; v=1; b=UYAmn253JZDWKeCNFn1nBq1yH+chw5OfCIeB3S9O0Y1wUv2iq5JtRabNveYibAk/KvykznGj 47oiEsBC18L22WB80wdh5x/7rfRLL35x8zg17Zwe0K/7RMPn9pIHVspKWgV6NyJmIazoYIr2FSS jF+JPiAx7/NXNUxpliHsd+8I= X-Received: by 127.0.0.2 with SMTP id DvoPYY7687511xYQ0Izy8qqt; Wed, 28 Feb 2024 23:43:10 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.19414.1709192589555751098 for ; Wed, 28 Feb 2024 23:43:09 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-KK8T0C30OouZiuEIv0QCKQ-1; Thu, 29 Feb 2024 02:43:02 -0500 X-MC-Unique: KK8T0C30OouZiuEIv0QCKQ-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E8EEB83106C; Thu, 29 Feb 2024 07:43:01 +0000 (UTC) X-Received: from [10.39.192.138] (unknown [10.39.192.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7FA1111DCF0; Thu, 29 Feb 2024 07:42:59 +0000 (UTC) Message-ID: Date: Thu, 29 Feb 2024 08:42:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro To: Gerd Hoffmann Cc: devel@edk2.groups.io, Tom Lendacky , Jiewen Yao , Oliver Steffen , Erdem Aktas , Michael Roth , Ard Biesheuvel , Min Xu References: <20240222115435.85794-1-kraxel@redhat.com> <20240222115435.85794-3-kraxel@redhat.com> <453c3b30-8ab5-c258-d411-cf108761fd18@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9wSvMrDySyGMznkaCxl5HufYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UYAmn253; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/28/24 09:22, Gerd Hoffmann wrote: > On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: >> On 2/22/24 12:54, Gerd Hoffmann wrote: >>> Move code to clear the page tables to a nasm macro. >>> No functional change. >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 35 ++++++++++++----------- >>> 1 file changed, 19 insertions(+), 16 deletions(-) >>> >>> diff --git a/OvmfPkg/ResetVector/Ia32/PageTables64.asm b/OvmfPkg/ResetV= ector/Ia32/PageTables64.asm >>> index 6fec6f2beeea..378ba2feeb4f 100644 >>> --- a/OvmfPkg/ResetVector/Ia32/PageTables64.asm >>> +++ b/OvmfPkg/ResetVector/Ia32/PageTables64.asm >>> @@ -45,6 +45,24 @@ BITS 32 >>> %define TDX_BSP 1 >>> %define TDX_AP 2 >>> =20 >>> +; >>> +; For OVMF, build some initial page tables at >>> +; PcdOvmfSecPageTablesBase - (PcdOvmfSecPageTablesBase + 0x6000). >>> +; >>> +; This range should match with PcdOvmfSecPageTablesSize which is >>> +; declared in the FDF files. >>> +; >>> +; At the end of PEI, the pages tables will be rebuilt into a >>> +; more permanent location by DxeIpl. >>> +; >>> +%macro ClearOvmfPageTables 0 >>> + mov ecx, 6 * 0x1000 / 4 >>> + xor eax, eax >>> +.clearPageTablesMemoryLoop: >>> + mov dword[ecx * 4 + PT_ADDR (0) - 4], eax >>> + loop .clearPageTablesMemoryLoop >>> +%endmacro >>> + >>> ; >>> ; Modified: EAX, EBX, ECX, EDX >>> ; >> >> Ah, this made me read up on local labels: >> >> https://www.nasm.us/xdoc/2.16.01/html/nasmdoc3.html#section-3.9 >> >> Should we rather call the label >> >> ..@clearPageTablesMemoryLoop >> >> ? >=20 > I've tried that and something (which I don't remember) didn't work as > expected. Given that each branch which uses that macro will have a jump > label anyway (so the local label is expanded to something like > TdxBspInit.clearPageTablesMemoryLoop) I've figured this is good enough Sure, if you've tried it already, then the current method is fine! Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116135): https://edk2.groups.io/g/devel/message/116135 Mute This Topic: https://groups.io/mt/104506789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-