Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

["Michael Kubacki" <mikuback@linux.microsoft.com>]

What are the next steps?

Thanks,
Michael

On 9/15/2022 5:54 PM, Kinney, Michael D wrote:
> Hi Ard,
> 
> If there is content you do not think needs to follow the min quality criteria, perhaps it can be moved out of edk2 repo?  Maybe to edk2-staging or edk2-archive?
> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: Ard Biesheuvel <ardb@kernel.org>
>> Sent: Thursday, September 15, 2022 2:03 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>; devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Ard
>> Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
>> Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI
>>
>> On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D
>> <michael.d.kinney@intel.com> wrote:
>>>
>>> Ard,
>>>
>>> Why would you want to do that?  The whole point of CI is to establish a minimum quality level for all code in the project.
>>>
>>> They can be disabled with updates to the YAML file.  Checks can be disabled completely and may of the checks support
>> exception lists.
>>>
>>
>> If the only way to prevent this from happening is to turn it off again
>> in the YAML file, I'd prefer not to turn it on to begin with.
>>
>> I agree that code quality is important, but IMO the checks we have at
>> the moment are way too strict, and 90% of the time I spend on
>> reviewing and merging patches is on crustify and patchcheck errors.
>> This is simply not worth my time.