From: "PierreGondois" <pierre.gondois@arm.com>
To: sami.mujawar@arm.com, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 08/10] DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml
Date: Thu, 23 Sep 2021 08:49:08 +0100 [thread overview]
Message-ID: <f112f92d-f9c3-fd8d-b66c-7ecd5a4eb11d@arm.com> (raw)
In-Reply-To: <9346.1632325731402766050@groups.io>
Hi Sami,
Unfortunately this is still necessary,
cf
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=29900&view=logs&j=216bd3cb-36c2-5579-221e-bd2f77088687&t=156c6dac-d9ee-52ac-8143-8428ed0a9e36
ERROR - EFI coding style error
ERROR - *Error code: 8003
ERROR - *The #ifndef at the start of an include file should use both
prefix and postfix underscore characters, '_'
ERROR - *file: D:\a\1\s\DynamicTablesPkg\Include\Library\AmlLib\AmlLib.h
ERROR - *Line number: 623
ERROR - *The #ifndef name [DISABLE_NEW_DEPRECATED_INTERFACES] does not
follow the rules
Regards,
Pierre
On 9/22/21 4:48 PM, Sami Mujawar via Groups.Io wrote:
> Hi Pierre,
>
> On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
> 2- Disable the Ecc check 8003 for the following keyword:
> "DISABLE_NEW_DEPRECATED_INTERFACES"
> Indeed, this error has been corrected on the latest version of
> BaseTools, but is still triggered when using the older python
> packages containing the BaseTools.
>
> Can you check if the 8003 error needs to be disabled with latest
> Basetools, please? If not can you drop this part from the patch.
>
> Regards,
>
> Sami Mujawar
next prev parent reply other threads:[~2021-09-23 7:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:05 [PATCH v1 00/10] Various DynamicTablesPkg modifications PierreGondois
2021-06-23 11:05 ` [PATCH v1 01/10] DynamicTablesPkg: Extract AcpiTableHelperLib from TableHelperLib PierreGondois
2021-09-22 15:15 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 02/10] DynamicTablesPkg: Update TableHelperLib.inf PierreGondois
2021-09-22 15:16 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 03/10] DynamicTablesPkg: Rename single char input parameter PierreGondois
2021-09-22 15:20 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 04/10] DynamicTablesPkg: Add HexFromAscii() to AcpiHelperLib PierreGondois
2021-09-22 15:23 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 05/10] DynamicTablesPkg: Add AmlGetEisaIdFromString() " PierreGondois
2021-09-22 15:40 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 06/10] DynamicTablesPkg: Add Configuration Manager Object parser PierreGondois
2021-09-24 8:56 ` [edk2-devel] " Joey Gouly
2021-09-27 7:14 ` PierreGondois
2021-09-29 15:03 ` Joey Gouly
2021-06-23 11:05 ` [PATCH v1 07/10] DynamicTablesPkg: Use %a formatter in AmlDbgPrint PierreGondois
2021-09-22 15:44 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 08/10] DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml PierreGondois
2021-09-22 15:48 ` [edk2-devel] " Sami Mujawar
2021-09-23 7:49 ` PierreGondois [this message]
2021-06-23 11:05 ` [PATCH v1 09/10] DynamicTablesPkg: Deprecate Crs specific methods in AmlLib PierreGondois
2021-09-22 15:56 ` [edk2-devel] " Sami Mujawar
2021-06-23 11:05 ` [PATCH v1 10/10] DynamicTablesPkg: Rework AmlResourceDataCodegen.c/h PierreGondois
2021-09-22 16:04 ` [edk2-devel] " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f112f92d-f9c3-fd8d-b66c-7ecd5a4eb11d@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox