From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web08.1363.1632383351230341452
 for <devel@edk2.groups.io>;
 Thu, 23 Sep 2021 00:49:11 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBE9AD6E;
	Thu, 23 Sep 2021 00:49:09 -0700 (PDT)
Received: from [192.168.1.16] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 488E43F718;
	Thu, 23 Sep 2021 00:49:09 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v1 08/10] DynamicTablesPkg: Update DynamicTablesPkg.ci.yaml
To: sami.mujawar@arm.com, devel@edk2.groups.io
References: <20210623110525.6171-9-Pierre.Gondois@arm.com>
 <9346.1632325731402766050@groups.io>
From: "PierreGondois" <pierre.gondois@arm.com>
Message-ID: <f112f92d-f9c3-fd8d-b66c-7ecd5a4eb11d@arm.com>
Date: Thu, 23 Sep 2021 08:49:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <9346.1632325731402766050@groups.io>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Hi Sami,
Unfortunately this is still necessary,

cf
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=29900&view=logs&j=216bd3cb-36c2-5579-221e-bd2f77088687&t=156c6dac-d9ee-52ac-8143-8428ed0a9e36

ERROR - EFI coding style error
ERROR - *Error code: 8003
ERROR - *The #ifndef at the start of an include file should use both
prefix and postfix underscore characters, '_'
ERROR - *file: D:\a\1\s\DynamicTablesPkg\Include\Library\AmlLib\AmlLib.h
ERROR - *Line number: 623
ERROR - *The #ifndef name [DISABLE_NEW_DEPRECATED_INTERFACES] does not
follow the rules

Regards,

Pierre


On 9/22/21 4:48 PM, Sami Mujawar via Groups.Io wrote:
> Hi Pierre,
>
> On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote:
>
>     2- Disable the Ecc check 8003 for the following keyword:
>     "DISABLE_NEW_DEPRECATED_INTERFACES"
>     Indeed, this error has been corrected on the latest version of
>     BaseTools, but is still triggered when using the older python
>     packages containing the BaseTools.
>
> Can you check if the 8003 error needs to be disabled with latest
> Basetools, please? If not can you drop this part from the patch.
>
> Regards,
>
> Sami Mujawar