From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.476.1636045229130278447 for ; Thu, 04 Nov 2021 10:00:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=W1OEWo5q; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A4GfLc0013348; Thu, 4 Nov 2021 17:00:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=DHacAnV10ZT3Qs7QWFGCIc1LN9fLDQNijNC5B20l9sE=; b=W1OEWo5qzcXMCar5ZDKcKct1F/XaeOxGI2ql3EwkY9Bfm017LJDBvmHyJlDTtl8/R6Bp BE/bsi73z14dmI9TvP6CMFRYx6X/zaOEpT996Cj9Ne5FVOncEqeiuZPNLW028q7gCWQa JnVCiFvkHKbfbfNOXGnywrXgabbLfhvZcr492Tygfw4lo6kg6dIwadsz44B36GvAYVFz EPEQyJlY2CoL/19gVFAfPe+E1Mepj/f2NFp+DGXz95MD70akHNZs14/aC38S5FIcZnWb Jf5IBwuvVxgaIjyQs5qo4Vk6veGYPkmZQtPKX1r4oe27IUsZLEHfw2pZsP+oskO9FkZy 3A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3c4j3hahvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Nov 2021 17:00:26 +0000 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1A4GgRHi017732; Thu, 4 Nov 2021 17:00:25 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0b-001b2d01.pphosted.com with ESMTP id 3c4j3hahv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Nov 2021 17:00:25 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1A4Gwqka022322; Thu, 4 Nov 2021 17:00:25 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma04wdc.us.ibm.com with ESMTP id 3c0wpcdmqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Nov 2021 17:00:24 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1A4H0NaE34931068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Nov 2021 17:00:23 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA7096E059; Thu, 4 Nov 2021 17:00:23 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4BF456E054; Thu, 4 Nov 2021 17:00:21 +0000 (GMT) Received: from [9.65.75.52] (unknown [9.65.75.52]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 4 Nov 2021 17:00:20 +0000 (GMT) Message-ID: Date: Thu, 4 Nov 2021 18:58:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/1] OvmfPkg/AmdSev: remove unused SMM bits from .dsc and .fdf files To: Gerd Hoffmann , devel@edk2.groups.io Cc: Jiewen Yao , Ard Biesheuvel , Erdem Aktas , Tom Lendacky , James Bottomley , Brijesh Singh , Min Xu , Jordan Justen , Dov Murik References: <20211104092134.3537949-1-kraxel@redhat.com> From: "Dov Murik" In-Reply-To: <20211104092134.3537949-1-kraxel@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jhBGYtzMhKsj-mwCIfVhbFqJHU7_qNso X-Proofpoint-ORIG-GUID: s3dNZ-x0ZBiYJF6x44Sf1553qz8Od8IS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-04_05,2021-11-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 impostorscore=0 clxscore=1015 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111040063 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks Gerd, On 04/11/2021 11:21, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Dov Murik Tested-by: Dov Murik -Dov > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 47 ------------------------------------ > OvmfPkg/AmdSev/AmdSevX64.fdf | 15 ------------ > 2 files changed, 62 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 5ee54451169b..d54ef2916536 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -93,14 +93,6 @@ [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > XCODE:*_*_*_MTOC_FLAGS = -align 0x1000 > CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096 > > -# Force PE/COFF sections to be aligned at 4KB boundaries to support page level > -# protection of DXE_SMM_DRIVER/SMM_CORE modules > -[BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE] > - GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > - XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000 > - XCODE:*_*_*_MTOC_FLAGS = -align 0x1000 > - CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096 > - > ################################################################################ > # > # SKU Identification section - list of all SKU IDs supported by this Platform. > @@ -390,45 +382,6 @@ [LibraryClasses.common.UEFI_APPLICATION] > !endif > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > > -[LibraryClasses.common.DXE_SMM_DRIVER] > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - TimerLib|OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > - ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > - MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf > - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > - MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > - SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > -!ifdef $(DEBUG_ON_SERIAL_PORT) > - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > -!else > - DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > -!endif > - CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf > -!if $(SOURCE_DEBUG_ENABLE) == TRUE > - DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > -!endif > - BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > - PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > - > -[LibraryClasses.common.SMM_CORE] > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - TimerLib|OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > - ResetSystemLib|OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > - SmmCorePlatformHookLib|MdeModulePkg/Library/SmmCorePlatformHookLibNull/SmmCorePlatformHookLibNull.inf > - MemoryAllocationLib|MdeModulePkg/Library/PiSmmCoreMemoryAllocationLib/PiSmmCoreMemoryAllocationLib.inf > - ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > - SmmServicesTableLib|MdeModulePkg/Library/PiSmmCoreSmmServicesTableLib/PiSmmCoreSmmServicesTableLib.inf > -!ifdef $(DEBUG_ON_SERIAL_PORT) > - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > -!else > - DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > -!endif > - PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > - > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform. > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf > index 56626098862c..804ad4e2bb6b 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -445,18 +445,3 @@ [Rule.Common.SEC.RESET_VECTOR] > FILE RAW = $(NAMED_GUID) { > RAW BIN Align = 16 |.bin > } > - > -[Rule.Common.SMM_CORE] > - FILE SMM_CORE = $(NAMED_GUID) { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > - } > - > -[Rule.Common.DXE_SMM_DRIVER] > - FILE SMM = $(NAMED_GUID) { > - SMM_DEPEX SMM_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > - } >