From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.64]) by mx.groups.io with SMTP id smtpd.web10.14724.1635435327878973233 for ; Thu, 28 Oct 2021 08:35:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=UsenumsI; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.64, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1aeBGFSwaFB7AtMtx4ZnR4+/HJAMawSRYDVJgAW6+nkyBy2PjEAsNPaxHqADY9hSH93O+iTpDHMa/Gwq8AMbHnBBMO2g6qUvRHrJIQEWIvY+/TvDJrQC7wG5lORRRjqyzXsz3AF2UpLZFQ7y2xHtdjiNKphXCl8DFpChB1Rp26BwZM7mOfDGrBg59LNZVRFwET5+oW4cQ1EE8kUkoSf4lAvMZhxps4N7wcOb5vI7fh1m1WRdRqDuopx/eDz/Y2qNovzYraDcMtwpUGrPcGjZ4jfr+44fS+8ihWxgBN3om7FcgbnzxCcK5fH+LmjXvDflIbGUEVG+RYcNS11bb1Hww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDM+53dhqCTtUMENIw9B27L76gLJoErFDvaiCChMUgQ=; b=OSJ3Pt25KXtCW1BN+E0Bk1Y0Mt87GLUY5VgVNy0MhDo9nuJ0HVum91POfEQw19fc1fg5AN/kqf+F/eQ/p3ptKtl99yhTxabUZzm1U0Qff/FDQXwc5O5BppptpwNBijYKEiZ4L8TPJm8BTRzZliAQ52yM/CSrQKuBehRAOo/KGXE6Hx6KTYBjCl8CNC3y3ceBYcq0kCw6jVg6W/d0B6Xur69xOUARKhAEtpkSnTXJq82lLMNSrI4DfQcL3kq/E4rbiqDtMleIktN6tCqL6MQh86sH+1CJPkseH24Wb8czr4dmmQG4cQwMEaD0smLULC7rpdvZf7awz2TzpqLwqoH5Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDM+53dhqCTtUMENIw9B27L76gLJoErFDvaiCChMUgQ=; b=UsenumsIWPXZcnXR/Tju56M5y8ugX9nPwfd7DC6KXbH17NB8yTnvOuNLvtOcI/bT2lzEeLf/9Was3GuQncvSeteiRQglV9YTCvKmWcuLiWD+Y2SLIE6YX/qMbRvZg4NvDbGarvMA6DZVPX1TVIlLs5u0qqh1dGJsRLY6VNX74BA= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4525.namprd12.prod.outlook.com (2603:10b6:806:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct 2021 15:35:25 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::e4da:b3ea:a3ec:761c%7]) with mapi id 15.20.4628.020; Thu, 28 Oct 2021 15:35:25 +0000 Cc: brijesh.singh@amd.com, "devel@edk2.groups.io" , Erdem Aktas , James Bottomley , Tom Lendacky , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception To: "Yao, Jiewen" , "kraxel@redhat.com" , "Xu, Min M" References: <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com> <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org> <20211026061148.omqerrswnpgs3jin@sirius.home.kraxel.org> <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org> <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: Date: Thu, 28 Oct 2021 10:35:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: X-ClientProxiedBy: BL1PR13CA0417.namprd13.prod.outlook.com (2603:10b6:208:2c2::32) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from [10.236.30.107] (165.204.77.1) by BL1PR13CA0417.namprd13.prod.outlook.com (2603:10b6:208:2c2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.11 via Frontend Transport; Thu, 28 Oct 2021 15:35:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4dd4afc-cda8-4a44-5821-08d99a289009 X-MS-TrafficTypeDiagnostic: SA0PR12MB4525: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RVO6+Uuys9uUDDOLmJzyrN82KRAvTfF3WtByBpMQq6jTzyYtIFk2xOOjHsvjeF6vGw/xiBBiUYA4y7nRCSJ5YZf0820A2qJP+xpEf2GtMPDdIO7rAoP3wufoxFesk3tMcdYCMthhNxtI7nO4KGPiIk+VDXTLxyJ2QY9QPd9gtvGG48pf8jvUtthhOE01PUnPEZrB3uL0KbhYaUBFwmKoUF3z2u2Hg5eNmPQKlV/ReQtTcyd0pOMiSukEMhv9kg1Ltbvc4GkGHTyb+Lhw5mB4QUj0C0rOZ2sE1shrw+1fa5w0RYZDc9FDw+hJv9rSLRru+78rUStuL23Oq7g7bZzXJ/w3O6RQZJpp6qMBSWvkWLBTczlwOI573kmcRP4lRwAJGcZBs8/znHo2tI0GTFE+ct4x27zqq0Ws1EAzHcIAO3/h+EagzGlLCG4JgPijwMrTeWEOmw+Xj6ThUTGPWV5ziMMT94+4BTn5cmD/8jszb/ke4S75jehlAyZQ4wrwhRgsCIbS3X6E7aISQP/8gRHINnhgoVqcOrAfnLItIvlM34uwr+MOHO02H1z8OYEUgnEI+gbibgdyvmEdEkTcSxwBFC7uM0JdexCJ5nVrv4+Rl78JfKFihJeTWyUDZP0js5LGh3sFcZXeHjatE1TBF/JlNYTlMWQCs0rtEW4q9+SuxABHIdVLavygFqVq0J+wbhYlS+SDSZmWeT5pcn9MelIxU/Uuk83M0XE6tYKEHvuER/g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(956004)(4326008)(2616005)(36756003)(186003)(6486002)(66476007)(44832011)(31696002)(53546011)(2906002)(5660300002)(26005)(38100700002)(66556008)(54906003)(16576012)(316002)(110136005)(8676002)(508600001)(6666004)(66946007)(8936002)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzVUSDRGa3V3UFRtdFVYZmZySEc1ekxCLzNFUUsxcnM3MDg5WjBmV1hwa2dz?= =?utf-8?B?QzRxaXM4ejIvbWFsSGtTeEdmQk1ZM2JGYUpYM1JIdnlFUlNCczhmMUtnakZu?= =?utf-8?B?MU4zVVZPZ0RGb3BCOFhjOXc2V0sxTXpra3A0bVhoUURaanNKSVU3bE9yQmdj?= =?utf-8?B?L2x5cmpnZVdxaXU0VVVvSlNhSkFuVVVKY2FuV0ZkbXBQRkRIZUN0N2hHVlVu?= =?utf-8?B?YXZ2amt6MmI2MWtJRFFnZXdIRk1WYURjVktoZHM1TGprcFRYSlc3TkRodjZ1?= =?utf-8?B?Z1Z0aFV0ZGlEUks2YmRBNDJJSUtBRnc1c1MyV0xJakQ0bmZMa2VqTlNuZ2xM?= =?utf-8?B?ajAva2hQR2dURk1kNENGbkF3UlZFZ3IwOUJicFZ5SW4zT3dsS1lhNFBuZHZI?= =?utf-8?B?ekZiSkZIQVFJZmJJRkJxN0hhMDNrMmRUdktSV1RZTENtekZKSWpvZjNjcTJM?= =?utf-8?B?Y2lVQ2VQbyt4TjJEaVdWNXFqcTJDenVuMGlhOE1iRFVtUlExYlh6V21zYWNz?= =?utf-8?B?QTBIbCtDRTNNVWpXT0J2TVRxSXpoSE1FdWlteGJtRVRWbXpmOFVCbStRUXR5?= =?utf-8?B?QllmdVVtTVFPbkVKcjJGU3krQlhsYTltR2xjQkkvRGxBL2xMRmk4RjlnT2RQ?= =?utf-8?B?eGRQbVlpSlJPdHVXNTRBaW9ZR2ViYlRDNElId2l3VVhuc0lyRkludFNKbUta?= =?utf-8?B?dFFhcjVSNi9IM1U5MXd4NXk1QXBhTHN3WFRmOVFmd0ROZ2tMdzBoa09XQTg0?= =?utf-8?B?R2JNQ09CVndDVHpZczhYa3Z0TGIxcktuczJiTHMvTklFNWRUS2d5SWZsTTk5?= =?utf-8?B?QmQ2NmUyU2NaSGJIeExNc2N2RitNVXkvNVhxNkV1TUs0ZE5iQVR2SDdMT09Y?= =?utf-8?B?VFJXQUJmWWoyK2IwNlpkYmlBV1JBSWJiQlIvUTNTTE41N3R2ZUJxQk00RmJZ?= =?utf-8?B?ci96d0RnOGVtcmhHWVBhQi93aGlVbm50dU9tTDdQMHZSa1BMaXpLeFduYTM2?= =?utf-8?B?S1VDSmtuUWlUNlhEL2JSNWptNU5pcytjUVdvTVYvZnlSNlFBcTZYTndHVnBM?= =?utf-8?B?ckh4WkZ0Rzd3S3liaThMM1Q5YVRXU2JWTm0yOGZmSE9rMlZ0S0xVV3l1S3g1?= =?utf-8?B?NG1jNW9jZ3N6OW1NOFJLWnMrNlpwTmo1RHJjUTZVSTRUS2V0QUFCbHlBZDJY?= =?utf-8?B?TVA4RFRBVHAyRGRiVjZLY2ZDS3VEUG1IbWtIM2ZvbXZaUXZQL3ErdUphNHkr?= =?utf-8?B?cmNxWXFhSDZ3cE14ZG5RWExJcWhqK0EyWndCb2xMUHBacjZzVlJNcSt4WDE5?= =?utf-8?B?bXpaNGRSejE5Skw2UXAxZmUvRkJZM2RaQWttYXo4YkFNZ0hHOTlYdVRTNXU3?= =?utf-8?B?SS9uNGtoNDI4UkpzTU1zZVVXZ2VIUENSWVFOSWpBb0xvczVSS05HMlhvRDFy?= =?utf-8?B?dGE3Ulk1Y3RMYVZEbVpXcWtCcFRwVVMrZ2NnK2lKWFhudWt1c3lrOUNYY1dy?= =?utf-8?B?blR6b0FWYm5MMkgrSkdwVE1VZFliblNoRElpVTExV29MdUpPY3piazJlQWFU?= =?utf-8?B?STVWZitiamlTNDhrb0NlMDRSWUs4V2p4NGViSEZUR05XQVdGaXNDWU5acnRu?= =?utf-8?B?dkV0NzZkUGJINzNmeVVXWUovRmVhMWx3Y0JmYnRjSTVkN3NacWZyQXEwd3pi?= =?utf-8?B?aDI5UG5VNXRmT3loNWpVdmRNVFgwWExzWlNreUpHNlJWRWZqZlBZbjlLRDhQ?= =?utf-8?B?Y3lmcFYyVGJtZURLMnBMbjkwWUZHZG50YUVJNjdia1V1SHI3alRXbDY1U1oy?= =?utf-8?B?cG9UWmZzYlUxb3c1ZzBidnV6Qi91TlZLRXp6T2lkSnpHUjY4S3NvZlJIZ0k5?= =?utf-8?B?bWErMWhWeEVCWEtIQ1ZQaTZjZUdKSFkyTTU5WU51THFPczdYd3dBU1NTTkpT?= =?utf-8?B?aTNaV0grNkROMWZoQmpDTk9CcTJOS1lrRitTeUxCUlBseXA3d1AwRGJ0OTFs?= =?utf-8?B?bytUMHRKN1VCNmtkNEF1SFpZdGN4TVlMSGo1bWp6ZWVYU3RrMFZYZDRURzNU?= =?utf-8?B?dllzaXpFQitrcDFVT2NlVzM0L0g2MU44VXUzSGlWclZKclVFcldlK3lIZ3FI?= =?utf-8?B?dStUQzhaRitmRERiSm5La0NHS1AzOGZaV2FGR2VIQ3pzMUhRVkp6KytDY3h0?= =?utf-8?Q?574DcSuLCndHGRl+QglgcZc=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4dd4afc-cda8-4a44-5821-08d99a289009 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 15:35:25.8115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rQlfaJwsYvBJendSI9RcJ9Ux0FMeccJv6rp+9AiWSjCDNfomh1buEOlXmwA3F3qGvqoimyqVdyH2kYtCqTb0tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/27/21 8:59 PM, Yao, Jiewen wrote: > Hi Gerd > I tend to agree with you on the direction to use one TEE specific Exception lib. > > However, I have naming concern. > The VMG is very SEV specific term. I don't believe it is a right name to cover the TEE exception lib. > > If Brijesh agree to merge, I think we should rename it to a neutral name, such as TeeExitLib. > > What do you think, Brijesh? I am good with merging both the TDX and SEV feature into one library but I am not sure about the "TEE" name in it. TEE generally is used on the ARM. In Linux kernel and everywhere else we have been using the COCO (Confidential Computing), so something along that line makes much more sense. We can rename the library after the SNP patches are merged. I would prefer to avoid renaming because all of the SNP patches are Ack-ed. -Brijesh > > Thank you > Yao Jiewen > > >> -----Original Message----- >> From: kraxel@redhat.com >> Sent: Wednesday, October 27, 2021 3:20 PM >> To: Xu, Min M >> Cc: Brijesh Singh ; Yao, Jiewen >> ; devel@edk2.groups.io; Erdem Aktas >> ; James Bottomley ; Tom >> Lendacky ; Dong, Eric ; Ni, >> Ray ; Kumar, Rahul1 >> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: >> Add base support for the #VE exception >> >> Hi, >> >>>> How about adding the tdx exception handler to the existing library, so we >> don't >>>> have the churn of adding a new library everywhere *again*? >> >>> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in >> CpuExceptionHandlerLib, then include the corresponding source file in each >> *CpuExceptionHandlerLib.inf? >> >> No, I mean extend the existing VmgExitLib instead of adding a new >> VmTdExitLib, i.e. place the tdx handler in >> OvmfPkg/Library/VmgExitLib/TdxExitHandler.c >> >> take care, >> Gerd >