From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.32865.1613988074826473590
 for <devel@edk2.groups.io>;
 Mon, 22 Feb 2021 02:01:15 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b4UUZ9nR;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1613988074;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=31CeK3/GmvER6E4ATTJdxTyEp2ufwndLgUpUYmwv7Z0=;
	b=b4UUZ9nRqNCEvX3bBehPhAZRAudJ82OGEXYaPI4vAhKxV8yKpwGPhMKJ8vhTXG0hiprp2U
	tgsL+LxXrPydUA+YF7y3RcfltkuFOAffGsCj/qKNt6E7vjSPlf5ELNIsv6XcpNePcP0sMF
	klEBh3W62kpuBwV5/mnGJCJwvd4o+lI=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-540-2p5DTQdsOyCxFClTvzZvew-1; Mon, 22 Feb 2021 05:01:08 -0500
X-MC-Unique: 2p5DTQdsOyCxFClTvzZvew-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83AC01052062;
	Mon, 22 Feb 2021 10:00:57 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-67.ams2.redhat.com [10.36.113.67])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 12A8E1F418;
	Mon, 22 Feb 2021 10:00:52 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v7 01/10] OvmfPkg/CpuHotplugSmm: refactor hotplug logic
To: devel@edk2.groups.io, ankur.a.arora@oracle.com
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Aaron Young <aaron.young@oracle.com>
References: <20210219090444.1332380-1-ankur.a.arora@oracle.com>
 <20210219090444.1332380-2-ankur.a.arora@oracle.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <f1735bb9-aabe-c9c3-7245-608a64abaa3b@redhat.com>
Date: Mon, 22 Feb 2021 11:00:51 +0100
MIME-Version: 1.0
In-Reply-To: <20210219090444.1332380-2-ankur.a.arora@oracle.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/19/21 10:04, Ankur Arora wrote:
> Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into
> ProcessHotAddedCpus(). This is in preparation for supporting CPU
> hot-unplug.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Aaron Young <aaron.young@oracle.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132
> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Addresses these review comments from v6:
>      (1) s/EFI_ERROR(/EFI_ERROR (/
>      (2) Remove the empty line in the comment block above
>       ProcessHotAddedCpus().
>      () Nest the EFI_ERROR handling inside the (PluggedCount > 0) clause.
> 
>  OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 210 ++++++++++++++++++++++---------------
>  1 file changed, 126 insertions(+), 84 deletions(-)

LGTM, thanks
Laszlo