From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Cc: Yonghong Zhu <yonghong.zhu@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [PATCH v1 3/5] BaseTools: StrGather remove functions no one calls
Date: Thu, 15 Mar 2018 14:39:06 -0700 [thread overview]
Message-ID: <f18d4c9714574e9f817421cfdf73a5bad63af911.1521149858.git.jaben.carsey@intel.com> (raw)
In-Reply-To: <cover.1521149858.git.jaben.carsey@intel.com>
In-Reply-To: <cover.1521149858.git.jaben.carsey@intel.com>
simplify the code and remove functions not called anymore
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
BaseTools/Source/Python/AutoGen/StrGather.py | 30 --------------------
1 file changed, 30 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/StrGather.py b/BaseTools/Source/Python/AutoGen/StrGather.py
index e6f10142cb66..9c7dd1e40374 100644
--- a/BaseTools/Source/Python/AutoGen/StrGather.py
+++ b/BaseTools/Source/Python/AutoGen/StrGather.py
@@ -124,22 +124,6 @@ def DecToHexList(Dec, Digit = 8):
def AscToHexList(Ascii):
return ['0x{0:02X}'.format(ord(Item)) for Item in Ascii]
-## Create header of .h file
-#
-# Create a header of .h file
-#
-# @param BaseName: The basename of strings
-#
-# @retval Str: A string for .h file header
-#
-def CreateHFileHeader(BaseName):
- Str = ''
- for Item in H_C_FILE_HEADER:
- Str = WriteLine(Str, Item)
- Str = WriteLine(Str, '#ifndef _' + BaseName.upper() + '_STRINGS_DEFINE_H_')
- Str = WriteLine(Str, '#define _' + BaseName.upper() + '_STRINGS_DEFINE_H_')
- return Str
-
## Create content of .h file
#
# Create content of .h file
@@ -204,19 +188,6 @@ def CreateHFile(BaseName, UniObjectClass, IsCompatibleMode, UniGenCFlag):
return HFile
-## Create header of .c file
-#
-# Create a header of .c file
-#
-# @retval Str: A string for .c file header
-#
-def CreateCFileHeader():
- Str = ''
- for Item in H_C_FILE_HEADER:
- Str = WriteLine(Str, Item)
-
- return Str
-
## Create a buffer to store all items in an array
#
# @param BinBuffer Buffer to contain Binary data.
@@ -493,7 +464,6 @@ def CreateCFileEnd():
#
def CreateCFile(BaseName, UniObjectClass, IsCompatibleMode, FilterInfo):
CFile = ''
- #CFile = WriteLine(CFile, CreateCFileHeader())
CFile = WriteLine(CFile, CreateCFileContent(BaseName, UniObjectClass, IsCompatibleMode, None, FilterInfo))
CFile = WriteLine(CFile, CreateCFileEnd())
return CFile
--
2.16.2.windows.1
next prev parent reply other threads:[~2018-03-15 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 21:39 [PATCH v1 0/5] BaseTools: improve reuse and remove dead code Jaben Carsey
2018-03-15 21:39 ` [PATCH v1 1/5] BaseTools: StrGather has redundant declaration Jaben Carsey
2018-03-15 21:39 ` [PATCH v1 2/5] BaseTools: StrGather simplify string/int conversion functions Jaben Carsey
2018-03-15 21:39 ` Jaben Carsey [this message]
2018-03-15 21:39 ` [PATCH v1 4/5] BaseTools: FdfParser & FdfParserLite refactor regular expression for GUIDs Jaben Carsey
2018-03-15 21:39 ` [PATCH v1 5/5] BaseTools: FdfParser remove class never used Jaben Carsey
2018-03-20 8:26 ` [PATCH v1 0/5] BaseTools: improve reuse and remove dead code Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18d4c9714574e9f817421cfdf73a5bad63af911.1521149858.git.jaben.carsey@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox