From: "René Treffer" <treffer@measite.de>
To: devel@edk2.groups.io
Cc: Pete Batard <pete@akeo.ie>, Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix dwc2 reset on raspberry pi boards
Date: Fri, 12 Mar 2021 18:42:06 +0100 [thread overview]
Message-ID: <f1b4acaa-8d12-5f58-d958-f10f945cfaf0@measite.de> (raw)
In-Reply-To: <CAMj1kXF-jQHTXpf2V-JiY90OtOgXe7Ljt3KJeFOg2x+-Pd+jOw@mail.gmail.com>
DwHcReset expects attributes as the second argument. A reset is
performed if the passed attribute is valued. However 0 is not a valid
attribute and will thus never cause a controller reset.
Passing EFI_USB_HC_RESET_HOST_CONTROLLER will reset the dwc2 controller
as expected.
This enables the USB 2.0 port of the raspberry compute module 4.
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Signed-off-by: René Treffer <treffer@measite.de>
---
Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
index bada13a6cd..bb228e62d9 100644
--- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
+++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
@@ -140,7 +140,7 @@ DriverStart (
* UsbBusDxe as of b4e96b82b4e2e47e95014b51787ba5b43abac784 expects
* the HCD to do this. There is no agent invoking DwHcReset anymore.
*/
- DwHcReset (&DwHc->DwUsbOtgHc, 0);
+ DwHcReset (&DwHc->DwUsbOtgHc, EFI_USB_HC_RESET_HOST_CONTROLLER);
DwHcSetState (&DwHc->DwUsbOtgHc, EfiUsbHcStateOperational);
Status = gBS->InstallMultipleProtocolInterfaces (
--
2.27.0
next prev parent reply other threads:[~2021-03-12 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 12:40 [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix dwc2 reset on raspberry pi boards treffer+groups.io
2021-03-11 21:50 ` [edk2-devel] " Samer El-Haj-Mahmoud
[not found] ` <166B6833F171D19D.3362@groups.io>
2021-03-12 15:17 ` Samer El-Haj-Mahmoud
2021-03-12 16:00 ` Ard Biesheuvel
2021-03-12 17:42 ` René Treffer [this message]
2021-03-12 17:43 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b4acaa-8d12-5f58-d958-f10f945cfaf0@measite.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox