From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web12.54307.1606234959591632283 for ; Tue, 24 Nov 2020 08:22:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=CadG8d7d; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AOG20ZO020970; Tue, 24 Nov 2020 11:22:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=vL3si94VBFcZ7ojc6CqrSyRKf7BDGozRNwngtAxul60=; b=CadG8d7ddVbPjNxLHbNhdJIsPqRaqn1enFfZ/NE+qKsfPjfB2UQcHpKYDsLbINAXgTbd gJbPa6ozRbBOkKpJR7OUj96+/7dqdknRc5xcN6AyxxAtKVR6NXKlYtBqnQHOiEbdSYFy YFaQ2riOigqbQu7maehe8B+Idfmd9UACjPifRIAy0y5pmgMtb+kehaHD6nfRgk8BH0TP QOnWDx38jRaBBJ2F4Y9deK/GCbjQB45LbnHg0r4oF86ealad3HRFI4sZt+glrGXk9bmg 63spA5d8sonoxrgbHjScs0ZLtLJv7mbzlrM08zazK1R3epSTjyxavDisE/crYuqBQIDq Cw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 350rn9jaeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 11:22:37 -0500 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AOG28Nn022355; Tue, 24 Nov 2020 11:22:37 -0500 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 350rn9jae8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 11:22:36 -0500 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AOGM58C027088; Tue, 24 Nov 2020 16:22:36 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma03dal.us.ibm.com with ESMTP id 34xth9euk7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 16:22:36 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AOGMWfr10682920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Nov 2020 16:22:32 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0B817805F; Tue, 24 Nov 2020 16:22:32 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED8117805E; Tue, 24 Nov 2020 16:22:29 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.194.234]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 24 Nov 2020 16:22:29 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: devel@edk2.groups.io, lersek@redhat.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Tue, 24 Nov 2020 08:22:28 -0800 In-Reply-To: References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-3-jejb@linux.ibm.com> <28e99174-79b3-e805-b977-5fed0071a702@redhat.com> <06b9425507ab8c1b35d377cf9bba155b0cc44147.camel@linux.ibm.com> <3b7899fa-fa52-7652-2d2a-d4ec67ece34d@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-24_04:2020-11-24,2020-11-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240098 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2020-11-24 at 16:58 +0100, Laszlo Ersek wrote: > On 11/24/20 15:54, Laszlo Ersek wrote: [...] > Perhaps I can make that recommendation / request more detailed too: > > > * drop: > > - UefiRuntimeServicesTableLib: no use of "gRT" > > - ReportStatusCodeLib: commit 0a0566d5edad is not relevant, because > we justifiedly removed TryRunningQemuKernel() > > - XenPlatformLib: as discussed before; substitute FALSE for each > XenDetected() call, and compress the resultant code All dropped. > * keep: > > - BaseLib: for CpuDeadLoop() > > - MemoryAllocationLib: for FreePool() > > - UefiBootServicesTableLib: for gBS->xxx() > > - BaseMemoryLib: for CompareMem() > > - DebugLib: for DEBUG() and ASSERT() > > - PcdLib: for PcdGet16 (PcdOvmfHostBridgePciDevId) > > - UefiBootManagerLib: for APIs central to the functionality of > PlatformBootManagerLibGrub > > - BootLogoLib: for BootLogoEnableLogo() > > - DevicePathLib: for a bunch of device path manipulation > > - PciLib: mainly for the functions called in PciAcpiInitialization() > > - UefiLib: for EfiEventGroupSignal() etc > > - PlatformBmPrintScLib: for PlatformBmPrintScRegisterHandler() -- > this is responsible for printing the boot option processing steps to > the UEFI console > > - Tcg2PhysicalPresenceLib: for > Tcg2PhysicalItPresenceLibProcessRequest() -- we preserve TPM support > > > Then leaving the trimming of [Packages] to the end makes sense -- > after trimming everything else, try to remove each package DEC in > isolation, and see if the lib instance continues to build. I can't seem to remove any packages. Even the source debug agent one is used by the uart devices. It seems I can get rid of PcdFSBClock and in the protocols section (with some header file removal) gEfiDecompressProtocolGuid gEfiS3SaveStateProtocolGuid James