From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.7148.1624539607872509306 for ; Thu, 24 Jun 2021 06:00:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QNBNfhNF; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624539607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=arM6cSXRBGIYQ+V8/DPpB9m7ZiGssyhOdbyu7BZ7gCE=; b=QNBNfhNFvquLMDJqj8M91n6ax1QGA5F/5x+dzdLGko2LD1A0p4GMj1P5RRyWj3OahU0XeI 1uTLvS9wjcroT61Mz52EH7m3J4QDDxinUcZZ92YwtaZuOqhU2mnKWDdvJW3ADcRyifrojg I427GXnkLT0u+x3wHX/4t6AmffOqeG8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-52-efMqiJOKOm6l9w8H2ErVkg-1; Thu, 24 Jun 2021 09:00:03 -0400 X-MC-Unique: efMqiJOKOm6l9w8H2ErVkg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EAEC57221; Thu, 24 Jun 2021 13:00:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79A3B1700F; Thu, 24 Jun 2021 12:59:59 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 5/5] ArmVirtPkg: Enable Acpiview for ArmVirtPkg To: devel@edk2.groups.io, pierre.gondois@arm.com, Sami Mujawar Cc: Ard Biesheuvel , Leif Lindholm , Akanksha Jain , Alexandru Elisei References: <20210623140640.16754-1-Pierre.Gondois@arm.com> <20210623140640.16754-6-Pierre.Gondois@arm.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 24 Jun 2021 14:59:57 +0200 MIME-Version: 1.0 In-Reply-To: <20210623140640.16754-6-Pierre.Gondois@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/23/21 16:06, PierreGondois wrote: > From: Sami Mujawar > > Acpiview is a command line tool allowing to display, dump, or > check installed ACPI tables. Add the tool to ArmVirt platforms. > > Signed-off-by: Sami Mujawar > Signed-off-by: Pierre Gondois > --- > ArmVirtPkg/ArmVirt.dsc.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index d9abadbe708c..269ac4990a6c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2021, Arm Limited. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > # Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved. > # Copyright (c) Microsoft Corporation. > @@ -398,6 +398,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf > NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > !if $(NETWORK_IP6_ENABLE) == TRUE > I disagree with this patch, as it will cause the Shell binary in all ArmVirtPkg platforms to include the (rather large) ACPIVIEW command. ACPIVIEW is super useful for when the tables are (dynamically) generated by the firmware itself, but that does not apply to the Qemu and Xen platforms. Note NETWORK_IP6_ENABLE: UefiShellNetwork2CommandsLib is only hooked into the shell application if NETWORK_IP6_ENABLE is TRUE. Please add DEFINE ACPIVIEW_ENABLE = TRUE to "ArmVirtPkg/ArmVirtKvmTool.dsc", and in "ArmVirtPkg/ArmVirt.dsc.inc", include the new command lib conditionally on ACPIVIEW_ENABLE being TRUE. (Can be in the same patch.) Acked-by: Laszlo Ersek Thanks Laszlo