Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg

["PierreGondois" <pierre.gondois@arm.com>]

Hello Jiewen,

On 11/21/23 12:27, Yao, Jiewen wrote:
> Why CryptoPkg needs to depend on ArmPkg?
> 
> Can we move content to MdePkg?

The OpensslLib needs to discover the native instruction supported by the
underlying platform before using them. This could also be done through the
MdePkg as you suggested. The v2 is implemented that way:
https://edk2.groups.io/g/devel/message/110953

Also, as noted by Leif, it seems there is already a dependency over ArmPkg:
# git grep ArmPkg CryptoPkg/
CryptoPkg/CryptoPkg.dsc:  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
CryptoPkg/CryptoPkg.dsc:  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
CryptoPkg/CryptoPkg.dsc:  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
CryptoPkg/CryptoPkgMbedTls.dsc:  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
CryptoPkg/CryptoPkgMbedTls.dsc:  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
CryptoPkg/CryptoPkgMbedTls.dsc:  PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf

Both solutions suit me (discovering capabilities through ArmPkg or MdePkg),
I just need to know which one is preferred,

Regards,
Pierre

> 
>> -----Original Message-----
>> From: Pierre Gondois <pierre.gondois@arm.com>
>> Sent: Tuesday, November 21, 2023 4:47 PM
>> To: devel@edk2.groups.io
>> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu, Xiaoyu1
>> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Leif Lindholm
>> <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
>> Sami Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann
>> <kraxel@redhat.com>
>> Subject: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon
>> ArmPkg
>>
>> Allow dependency upon ArmPkg to pass the dependency Check.
>>
>> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
>> ---
>>   CryptoPkg/CryptoPkg.ci.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
>> index f961d85927c0..3bbb220d3224 100644
>> --- a/CryptoPkg/CryptoPkg.ci.yaml
>> +++ b/CryptoPkg/CryptoPkg.ci.yaml
>> @@ -69,6 +69,7 @@
>>       },
>>
>>       "DependencyCheck": {
>>
>>           "AcceptableDependencies": [
>>
>> +            "ArmPkg/ArmPkg.dec",
>>
>>               "MdePkg/MdePkg.dec",
>>
>>               "MdeModulePkg/MdeModulePkg.dec",
>>
>>               "CryptoPkg/CryptoPkg.dec",
>>
>> --
>> 2.25.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111544): https://edk2.groups.io/g/devel/message/111544
Mute This Topic: https://groups.io/mt/102725178/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-