From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 669197803D9 for ; Tue, 21 Nov 2023 12:59:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Yf+SJO0J86VPuxjB+uAjdhBfbF8klKMn5YYTg6nFB2I=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700571559; v=1; b=KTJm2GxdCkGfr5UJ3++As8j150dD+q7IQsOZOolT/EwM7gkgnIPwvCStQLcRntuct97uxtIA xtjVRnyNPm1LE77+DkTWE5wh7SaQ62lIcNYcur0CObQCu0+y10GbaUKQeOE/4onFxzwa5mIz4wL 0wsxvboyuruRho8Ffjn63AFU= X-Received: by 127.0.0.2 with SMTP id gfdQYY7687511x7uLIEjsFW9; Tue, 21 Nov 2023 04:59:19 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.39238.1700571558085736403 for ; Tue, 21 Nov 2023 04:59:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25BE2FEC; Tue, 21 Nov 2023 05:00:04 -0800 (PST) X-Received: from [10.34.100.114] (e126645.nice.arm.com [10.34.100.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E8FC3F7A6; Tue, 21 Nov 2023 04:59:16 -0800 (PST) Message-ID: Date: Tue, 21 Nov 2023 13:59:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency upon ArmPkg To: "Yao, Jiewen" , "devel@edk2.groups.io" , Leif Lindholm Cc: "Li, Yi1" , "Lu, Xiaoyu1" , "Jiang, Guomin" , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann References: <20231121084715.1393672-1-pierre.gondois@arm.com> <20231121084715.1393672-3-pierre.gondois@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mNPq2aBX0iRkzAUWcX9nbFJEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KTJm2Gxd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Jiewen, On 11/21/23 12:27, Yao, Jiewen wrote: > Why CryptoPkg needs to depend on ArmPkg? >=20 > Can we move content to MdePkg? The OpensslLib needs to discover the native instruction supported by the underlying platform before using them. This could also be done through the MdePkg as you suggested. The v2 is implemented that way: https://edk2.groups.io/g/devel/message/110953 Also, as noted by Leif, it seems there is already a dependency over ArmPkg: # git grep ArmPkg CryptoPkg/ CryptoPkg/CryptoPkg.dsc: ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf CryptoPkg/CryptoPkg.dsc: NULL|ArmPkg/Library/CompilerIntrinsicsLib/Compile= rIntrinsicsLib.inf CryptoPkg/CryptoPkg.dsc: ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/Ar= mSoftFloatLib.inf CryptoPkg/CryptoPkgMbedTls.dsc: NULL|ArmPkg/Library/CompilerIntrinsicsLib/= CompilerIntrinsicsLib.inf CryptoPkg/CryptoPkgMbedTls.dsc: ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloa= tLib/ArmSoftFloatLib.inf CryptoPkg/CryptoPkgMbedTls.dsc: PeiServicesTablePointerLib|ArmPkg/Library/= PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf Both solutions suit me (discovering capabilities through ArmPkg or MdePkg), I just need to know which one is preferred, Regards, Pierre >=20 >> -----Original Message----- >> From: Pierre Gondois >> Sent: Tuesday, November 21, 2023 4:47 PM >> To: devel@edk2.groups.io >> Cc: Yao, Jiewen ; Li, Yi1 ; Lu, = Xiaoyu1 >> ; Jiang, Guomin ; Leif Lin= dholm >> ; Ard Biesheuvel ; >> Sami Mujawar ; Gerd Hoffmann >> >> Subject: [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow dependency up= on >> ArmPkg >> >> Allow dependency upon ArmPkg to pass the dependency Check. >> >> Signed-off-by: Pierre Gondois >> --- >> CryptoPkg/CryptoPkg.ci.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml >> index f961d85927c0..3bbb220d3224 100644 >> --- a/CryptoPkg/CryptoPkg.ci.yaml >> +++ b/CryptoPkg/CryptoPkg.ci.yaml >> @@ -69,6 +69,7 @@ >> }, >> >> "DependencyCheck": { >> >> "AcceptableDependencies": [ >> >> + "ArmPkg/ArmPkg.dec", >> >> "MdePkg/MdePkg.dec", >> >> "MdeModulePkg/MdeModulePkg.dec", >> >> "CryptoPkg/CryptoPkg.dec", >> >> -- >> 2.25.1 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111544): https://edk2.groups.io/g/devel/message/111544 Mute This Topic: https://groups.io/mt/102725178/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-