Re: [PATCH v4 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

[Laszlo Ersek <lersek@redhat.com>]

Hi,

On 06/23/17 22:41, Supreeth Venkatesh wrote:
> *** 
> PI v1.5 Specification Volume 4 defines Management Mode Core Interface.
> In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. 
> PI specification v1.5 defines the following new file types:
> #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E
> #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F
> The following changes are necessitated in order to support the above changes to the specification. 
> 
> Changes Since v3:
> (*) Update Review Comments from Liming, Felix.
> (*) Directly define FV file types MM_STANDALONE / MM_CORE_STANDALONE
> and module types MM_STANDALONE / MM_CORE_STANDALONE
> i.e., with MM prefix instead of SMM prefix.
> 
> Changes Since v2:
> Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI Specification v1.5 VOL3, 
> but not defined in VOL4.
> 
> Changes Since v1:
> Corrected Version check HEX Value "0x00010032" (1 and 50), not 0x0001000A (1 and 10)
> ***

I have a generic comment for this series (sorry that I'm making it this
late; I'm somewhat surprised that others haven't pointed out the same yet):

Every patch in the series has the exact same subject:

  BaseTools: Tools change to support PI v1.5 Specification.

Unfortunately, that's useless. The commit message *bodies* look great
and thoughtful, but the subject lines convey zero meaning.

Please replace every subject with a meaningful summary of the larger
commit message, such that the subject line still fits in 74 characters
or so. For example, for the first two patches:

BaseTools/GenFfs: add FFS file types for management mode modules
BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers

and so on.

Thanks,
Laszlo