From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 760D021A07A9C for ; Fri, 23 Jun 2017 14:17:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49D6F3A835B; Fri, 23 Jun 2017 21:19:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 49D6F3A835B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 49D6F3A835B Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-34.phx2.redhat.com [10.3.117.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42D745C685; Fri, 23 Jun 2017 21:19:21 +0000 (UTC) To: Supreeth Venkatesh , edk2-devel@lists.01.org Cc: jonathan.zhang@cavium.com, liming.gao@intel.com, leif.lindholm@linaro.org, felixp@ami.com, michael.d.kinney@intel.com, jbrasen@qti.qualcomm.com References: <1498250516-47996-1-git-send-email-supreeth.venkatesh@arm.com> From: Laszlo Ersek Message-ID: Date: Fri, 23 Jun 2017 23:19:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1498250516-47996-1-git-send-email-supreeth.venkatesh@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 23 Jun 2017 21:19:23 +0000 (UTC) Subject: Re: [PATCH v4 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification *** X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 21:17:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 06/23/17 22:41, Supreeth Venkatesh wrote: > *** > PI v1.5 Specification Volume 4 defines Management Mode Core Interface. > In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. > PI specification v1.5 defines the following new file types: > #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F > The following changes are necessitated in order to support the above changes to the specification. > > Changes Since v3: > (*) Update Review Comments from Liming, Felix. > (*) Directly define FV file types MM_STANDALONE / MM_CORE_STANDALONE > and module types MM_STANDALONE / MM_CORE_STANDALONE > i.e., with MM prefix instead of SMM prefix. > > Changes Since v2: > Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI Specification v1.5 VOL3, > but not defined in VOL4. > > Changes Since v1: > Corrected Version check HEX Value "0x00010032" (1 and 50), not 0x0001000A (1 and 10) > *** I have a generic comment for this series (sorry that I'm making it this late; I'm somewhat surprised that others haven't pointed out the same yet): Every patch in the series has the exact same subject: BaseTools: Tools change to support PI v1.5 Specification. Unfortunately, that's useless. The commit message *bodies* look great and thoughtful, but the subject lines convey zero meaning. Please replace every subject with a meaningful summary of the larger commit message, such that the subject line still fits in 74 characters or so. For example, for the first two patches: BaseTools/GenFfs: add FFS file types for management mode modules BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers and so on. Thanks, Laszlo