public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Javeed, Ashraf" <ashraf.javeed@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
Date: Fri, 7 Feb 2020 07:00:23 +0000	[thread overview]
Message-ID: <f1d418efd40c46eab8fb42ab21199300@intel.com> (raw)
In-Reply-To: <20200206103739.18732-1-ashraf.javeed@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
> 
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
>  };
> 
>  ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
> -/// byte field representing one PCI standerd feature defined in the PCI Express Base
> -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
> +/// to its version, with each byte field represents one PCI Express feature and
> +/// its bitmask define the legal combinations to represent all the valid combinations
> +/// of its attributes, defined in the PCI Express Base Specification.
>  ///
>  typedef struct {
>    EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE  DeviceCtlMPS;
> @@ -384,7 +380,6 @@ typedef struct {
>    EFI_PCI_EXPRESS_CTO_SUPPORT       CTOsupport;
>    EFI_PCI_EXPRESS_CPM               LinkCtlCPM;
>    EFI_PCI_EXPRESS_L1PM_SUBSTATES    L1PMSubstates;
> -  EFI_PCI_EXPRESS_RESERVES          Reserves[114];
>  } EFI_PCI_EXPRESS_DEVICE_POLICY;
> 
>  ///
> --
> 2.21.0.windows.1


  reply	other threads:[~2020-02-07  7:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 10:37 [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Javeed, Ashraf
2020-02-07  7:00 ` Liming Gao [this message]
2020-02-10  0:39 ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1d418efd40c46eab8fb42ab21199300@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox