* [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
@ 2020-02-06 10:37 Javeed, Ashraf
2020-02-07 7:00 ` Liming Gao
2020-02-10 0:39 ` Ni, Ray
0 siblings, 2 replies; 3+ messages in thread
From: Javeed, Ashraf @ 2020-02-06 10:37 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao, Ray Ni
Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
index dc58268..bb2c8c8 100644
--- a/MdePkg/Include/Protocol/PciExpressPlatform.h
+++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
@@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
};
///
-/// Reserves for future use
-///
-typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
-
-///
-/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
-/// byte field representing one PCI standerd feature defined in the PCI Express Base
-/// Specification 4.0, version 1.0.
+/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
+/// to its version, with each byte field represents one PCI Express feature and
+/// its bitmask define the legal combinations to represent all the valid combinations
+/// of its attributes, defined in the PCI Express Base Specification.
///
typedef struct {
EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE DeviceCtlMPS;
@@ -384,7 +380,6 @@ typedef struct {
EFI_PCI_EXPRESS_CTO_SUPPORT CTOsupport;
EFI_PCI_EXPRESS_CPM LinkCtlCPM;
EFI_PCI_EXPRESS_L1PM_SUBSTATES L1PMSubstates;
- EFI_PCI_EXPRESS_RESERVES Reserves[114];
} EFI_PCI_EXPRESS_DEVICE_POLICY;
///
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
2020-02-06 10:37 [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Javeed, Ashraf
@ 2020-02-07 7:00 ` Liming Gao
2020-02-10 0:39 ` Ni, Ray
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-02-07 7:00 UTC (permalink / raw)
To: Javeed, Ashraf, devel@edk2.groups.io; +Cc: Kinney, Michael D, Ni, Ray
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
>
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
> };
>
> ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
> -/// byte field representing one PCI standerd feature defined in the PCI Express Base
> -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
> +/// to its version, with each byte field represents one PCI Express feature and
> +/// its bitmask define the legal combinations to represent all the valid combinations
> +/// of its attributes, defined in the PCI Express Base Specification.
> ///
> typedef struct {
> EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE DeviceCtlMPS;
> @@ -384,7 +380,6 @@ typedef struct {
> EFI_PCI_EXPRESS_CTO_SUPPORT CTOsupport;
> EFI_PCI_EXPRESS_CPM LinkCtlCPM;
> EFI_PCI_EXPRESS_L1PM_SUBSTATES L1PMSubstates;
> - EFI_PCI_EXPRESS_RESERVES Reserves[114];
> } EFI_PCI_EXPRESS_DEVICE_POLICY;
>
> ///
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
2020-02-06 10:37 [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Javeed, Ashraf
2020-02-07 7:00 ` Liming Gao
@ 2020-02-10 0:39 ` Ni, Ray
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2020-02-10 0:39 UTC (permalink / raw)
To: Javeed, Ashraf, devel@edk2.groups.io; +Cc: Kinney, Michael D, Gao, Liming
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member
>
> Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Include/Protocol/PciExpressPlatform.h
> index dc58268..bb2c8c8 100644
> --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES {
> };
>
> ///
> -/// Reserves for future use
> -///
> -typedef UINT8 EFI_PCI_EXPRESS_RESERVES;
> -
> -///
> -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with each
> -/// byte field representing one PCI standerd feature defined in the PCI Express Base
> -/// Specification 4.0, version 1.0.
> +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definition corresponding
> +/// to its version, with each byte field represents one PCI Express feature and
> +/// its bitmask define the legal combinations to represent all the valid combinations
> +/// of its attributes, defined in the PCI Express Base Specification.
> ///
> typedef struct {
> EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE DeviceCtlMPS;
> @@ -384,7 +380,6 @@ typedef struct {
> EFI_PCI_EXPRESS_CTO_SUPPORT CTOsupport;
> EFI_PCI_EXPRESS_CPM LinkCtlCPM;
> EFI_PCI_EXPRESS_L1PM_SUBSTATES L1PMSubstates;
> - EFI_PCI_EXPRESS_RESERVES Reserves[114];
> } EFI_PCI_EXPRESS_DEVICE_POLICY;
>
> ///
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-10 0:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-06 10:37 [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Javeed, Ashraf
2020-02-07 7:00 ` Liming Gao
2020-02-10 0:39 ` Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox