Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

["Laszlo Ersek" <lersek@redhat.com>]

On 09/07/20 15:58, Philippe Mathieu-Daudé wrote:
> On 9/2/20 5:12 PM, Paul wrote:
>> [AMD Public Use]
>>
>> Hi Lazlo,
>>
>> Thanks for the feedback.  Noted, I'll spell it out in the future.  'Last initial' was habit from a team I used to work with.
>>
>> Thanks,
>> Paul
>>
>>
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com> 
>> Sent: Wednesday, September 2, 2020 1:58 AM
>> To: devel@edk2.groups.io; Grimes, Paul <Paul.Grimes@amd.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
>> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition
>>
>> [CAUTION: External Email]
>>
>> Hi Paul,
>>
>> meta:
>>
>> On 08/27/20 22:40, Paul wrote:
>>> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but 
>>> should be 0x02 per the ACPI Specification.
>>>
>>> REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>>> bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&amp;data=02%7C01%7Cp
>>> aul.grimes%40amd.com%7C51cbad882a354dd9f33108d84f1e5a56%7C3dd8961fe488
>>> 4e608e11a82d994e183d%7C0%7C0%7C637346339077687090&amp;sdata=WT8dJXxJhK
>>> LhXU4qGObyYo3KN91WBs3%2FTesgkYdzssA%3D&amp;reserved=0
>>>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>> Signed-off-by: Paul G <paul.grimes@amd.com>
>>> ---
>>>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> please consider setting the "user.name" git config knob to your full name. We now have:
>>
>> commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0
>> Author: Paul <paul.grimes@amd.com>
>> Date:   Fri Aug 28 04:40:51 2020 +0800
>>
>>     MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition
>>
>> and I like to be friendly :) but I think the Author field should state, in general, the full name, not just the first name.
>>
>>
>> Similary, the Signed-off-by tag at the end of the commit message should carry the full name too. Please see section "Developer Certificate of Origin" in "ReadMe.rst":
>>
>> """
>> Signed-off-by: Developer Name developer@example.org
>>
>> where ``Developer Name`` is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing.
>> """
>>
>> It's quite obvious from the email address that "Paul G" stands for Paul Grimes, but still spell it out.
> 
> I just notice this and was going to make a comment :)
> 
> We can not fix the S-o-b tag, but Paul can fix his author name by
> adding his entry in the .mailmap file:
> 
> -- >8 --
> diff --git a/.mailmap b/.mailmap
> index ba246ff6cd80..f3a4a5718e67 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -52,6 +52,7 @@ Michael Kubacki <michael.a.kubacki@intel.com>
>  Michael Kubacki <michael.a.kubacki@intel.com> </o=Intel/ou=External
> (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72>
>  Ming Tan <ming.tan@intel.com>
>  Nikolai Saoukh <nms@otdel-1.org>
> +Paul Grimes <paul.grimes@amd.com>
>  Philippe Mathieu-Daudé <philmd@redhat.com>
>  Ray Ni <ray.ni@intel.com>
>  Ray Ni <ray.ni@intel.com> <C:/Program Files
> (x86)/Git/O=Intel/OU=Pacifica02/cn=Recipients/cn=rni2>
> ---
> 

Right, please see here:

[edk2-devel] [PATCH 18/22] .mailmap: add entry for Paul Grimes
https://edk2.groups.io/g/devel/message/65108
http://mid.mail-archive.com/20200907193102.30535-19-lersek@redhat.com

Thanks!
Laszlo