From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.15508.1599552648957765963 for ; Tue, 08 Sep 2020 01:10:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hLNCcARz; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599552648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmyIfZ8lK2tsEtQXrjHL0KM0Zo5SPMoAzk45MDBDKHI=; b=hLNCcARzoTdautbSFqOgsZsWHsbk5IFFaYJjkSmWPo1/KxKMjbmk4Fd4E7RH40go/w+Dhc 9JfzfFMydvP9/snhenyX/GKUCKOtrV7pIsNw7gw4FSJslGJu9r9ugzthVyUC0Q8/nIsT1J CGmC0JtZPBLg09lEAq031zDwr74iBfg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-TFtQNb8_PryWf3vSmOlmQw-1; Tue, 08 Sep 2020 04:10:37 -0400 X-MC-Unique: TFtQNb8_PryWf3vSmOlmQw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A684064080; Tue, 8 Sep 2020 08:10:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-122.ams2.redhat.com [10.36.112.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6B8671775; Tue, 8 Sep 2020 08:10:33 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, paul.grimes@amd.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20200827204051.777-1-Paul.Grimes@amd.com> <20200827204051.777-2-Paul.Grimes@amd.com> <552971bb-aa6d-ab1b-9df8-895415ec176e@redhat.com> <37755166-1c9e-0d30-f4b1-6100cca6be7e@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 8 Sep 2020 10:10:32 +0200 MIME-Version: 1.0 In-Reply-To: <37755166-1c9e-0d30-f4b1-6100cca6be7e@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.004 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US On 09/07/20 15:58, Philippe Mathieu-Daudé wrote: > On 9/2/20 5:12 PM, Paul wrote: >> [AMD Public Use] >> >> Hi Lazlo, >> >> Thanks for the feedback. Noted, I'll spell it out in the future. 'Last initial' was habit from a team I used to work with. >> >> Thanks, >> Paul >> >> >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Wednesday, September 2, 2020 1:58 AM >> To: devel@edk2.groups.io; Grimes, Paul >> Cc: Michael D Kinney ; Liming Gao ; Zhiguang Liu >> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition >> >> [CAUTION: External Email] >> >> Hi Paul, >> >> meta: >> >> On 08/27/20 22:40, Paul wrote: >>> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but >>> should be 0x02 per the ACPI Specification. >>> >>> REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F >>> bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&data=02%7C01%7Cp >>> aul.grimes%40amd.com%7C51cbad882a354dd9f33108d84f1e5a56%7C3dd8961fe488 >>> 4e608e11a82d994e183d%7C0%7C0%7C637346339077687090&sdata=WT8dJXxJhK >>> LhXU4qGObyYo3KN91WBs3%2FTesgkYdzssA%3D&reserved=0 >>> >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> Signed-off-by: Paul G >>> --- >>> MdePkg/Include/IndustryStandard/Acpi10.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> please consider setting the "user.name" git config knob to your full name. We now have: >> >> commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0 >> Author: Paul >> Date: Fri Aug 28 04:40:51 2020 +0800 >> >> MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition >> >> and I like to be friendly :) but I think the Author field should state, in general, the full name, not just the first name. >> >> >> Similary, the Signed-off-by tag at the end of the commit message should carry the full name too. Please see section "Developer Certificate of Origin" in "ReadMe.rst": >> >> """ >> Signed-off-by: Developer Name developer@example.org >> >> where ``Developer Name`` is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing. >> """ >> >> It's quite obvious from the email address that "Paul G" stands for Paul Grimes, but still spell it out. > > I just notice this and was going to make a comment :) > > We can not fix the S-o-b tag, but Paul can fix his author name by > adding his entry in the .mailmap file: > > -- >8 -- > diff --git a/.mailmap b/.mailmap > index ba246ff6cd80..f3a4a5718e67 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -52,6 +52,7 @@ Michael Kubacki > Michael Kubacki (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72> > Ming Tan > Nikolai Saoukh > +Paul Grimes > Philippe Mathieu-Daudé > Ray Ni > Ray Ni (x86)/Git/O=Intel/OU=Pacifica02/cn=Recipients/cn=rni2> > --- > Right, please see here: [edk2-devel] [PATCH 18/22] .mailmap: add entry for Paul Grimes https://edk2.groups.io/g/devel/message/65108 http://mid.mail-archive.com/20200907193102.30535-19-lersek@redhat.com Thanks! Laszlo