Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

[Sudeep Holla <sudeep.holla@arm.com>]

Hi Evan,

On 27/07/16 15:23, Leif Lindholm wrote:
> Looks sensible to me.
>
> Unless Evan has any objections?
>
> On 27 July 2016 at 10:53, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>> is no point in supporting anything below v5.0. So set the PCD that
>> controls the ACPI table generation to the appropriate value.
>>
>> Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>> support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>  Platforms/ARM/Juno/ArmJuno.dsc | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc
>> index 45d9950decba..2e9ccfbad396 100644
>> --- a/Platforms/ARM/Juno/ArmJuno.dsc
>> +++ b/Platforms/ARM/Juno/ArmJuno.dsc
>> @@ -174,6 +174,8 @@
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
>>    gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>>
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>> +
>>  [PcdsPatchableInModule]
>>    # Console Resolution (Full HD)
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1920


And any feedback on this too ?

-- 
Regards,
Sudeep