From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sudeep.holla@arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id 2F5621A1DFC
 for <edk2-devel@lists.01.org>; Fri,  5 Aug 2016 07:43:24 -0700 (PDT)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D1B5D2F;
 Fri,  5 Aug 2016 07:44:47 -0700 (PDT)
Received: from [10.1.210.28] (unknown [10.1.210.28])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A31E3F215;
 Fri,  5 Aug 2016 07:43:22 -0700 (PDT)
To: Evan Lloyd <Evan.Lloyd@arm.com>
References: <1469613204-30017-1-git-send-email-sudeep.holla@arm.com>
 <CAF7UmSxfFGg=0dCYomJcpiLiqXsTWgBsPUy60CsO_AWtmxnaOQ@mail.gmail.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
 Sudeep Holla <sudeep.holla@arm.com>,
 "edk2-devel (edk2-devel@lists.01.org)" <edk2-devel@lists.01.org>,
 Linaro UEFI <linaro-uefi@lists.linaro.org>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <f1d97c59-a888-a4cc-2c30-f5985cc871d9@arm.com>
Date: Fri, 5 Aug 2016 15:43:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAF7UmSxfFGg=0dCYomJcpiLiqXsTWgBsPUy60CsO_AWtmxnaOQ@mail.gmail.com>
Subject: Re: [PATCH] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2016 14:43:24 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Evan,

On 27/07/16 15:23, Leif Lindholm wrote:
> Looks sensible to me.
>
> Unless Evan has any objections?
>
> On 27 July 2016 at 10:53, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> The ACPI spec predates the AARCH64 architecture by 5 versions, so there
>> is no point in supporting anything below v5.0. So set the PCD that
>> controls the ACPI table generation to the appropriate value.
>>
>> Based on the commit e0692789058e ("ArmVirtPkg/ArmVirtQemu: limit ACPI
>> support to v5.0 and higher") in the upstream TianoCore by Ard Biesheuvel
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>  Platforms/ARM/Juno/ArmJuno.dsc | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc
>> index 45d9950decba..2e9ccfbad396 100644
>> --- a/Platforms/ARM/Juno/ArmJuno.dsc
>> +++ b/Platforms/ARM/Juno/ArmJuno.dsc
>> @@ -174,6 +174,8 @@
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
>>    gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>>
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>> +
>>  [PcdsPatchableInModule]
>>    # Console Resolution (Full HD)
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1920


And any feedback on this too ?

-- 
Regards,
Sudeep