From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mx.groups.io with SMTP id smtpd.web08.61690.1606750576403445392 for ; Mon, 30 Nov 2020 07:36:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ANjKd/RB; spf=pass (domain: nuviainc.com, ip: 209.85.210.177, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f177.google.com with SMTP id b10so9224666pfo.4 for ; Mon, 30 Nov 2020 07:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=K6OMtonVcrLunssWIKYdXpxO+X/dzcMJddlcp3sT3Ug=; b=ANjKd/RBut9wUGJwLV1kJ0KMGDWwFXY7imxzo95LinJtYu8fYFI26pEpN9GYvrmOcM Tx8NqB6YyoReEvZ+k/fUPgNNV5HCrPmR4cA3ccsZ4EfBXhrOFPAWJ1m4iFJH7NIwosGr TWVHnSl4bySr7t/P2r1ZwXaOTT79fHfh4a54o98pF5EXeN8Eu5s0gVVtYY42WYu/qHAR dAJ67yy9vFhpR0KHr4UFi9xMDieGKd5AE3dmlx2ASZ0/s5+qYS/iNmAoK1v6Bd9uYqba rCNpDTfUzG9Qr4zhwPme8skwiuc/pDOi3n6ZliNaxj637bXNd2XW4ZSqB/w3JkmlMUEu asBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=K6OMtonVcrLunssWIKYdXpxO+X/dzcMJddlcp3sT3Ug=; b=r8rliDQ7AUiSejtIZ0uIHXtZV9tfcrBePLxDbfxUg4U8iNwxDQb43hvXHnOBRSZACr kBXzKB1jT63OwY8j5eLhbRMjj3BcktH2UDiwA2uCEy7uL9rrrxA2a8AJT2OyMbE+dSDs MNvOg+vEzdEAOpdqpbXbavSzCwfutQxOc9NLaz/nUUgZ1Ij3z+A8myCh5FIQeNX6ZnWZ qQwLXg3XucbAXTMxZnLfP/4eNREaHE7TpJikfTQHP/uaIsoyXsGQ48+sPXMtewa60OPN /N49V102TXdkz2+48xMVPiXzf7hJ9h5fA5BDOQd3libN3L2s8uuvyIqHjKV4+Yo6M9Ka txCw== X-Gm-Message-State: AOAM530UtMuuZReeDiMCCBsq9BedwRMyMkBkqUorOc1bnDFnkwLO0oRB z8MTwfZ5Z4JZu1C7LC2SuqOhuw== X-Google-Smtp-Source: ABdhPJzKGMZrEJqB/9LHgP98louSE5kT3mY/Y+guAFp11bh+8rstDTJ83PVf5mh7beSSiT5GApUFww== X-Received: by 2002:a62:8f4e:0:b029:18b:bd18:75b7 with SMTP id n75-20020a628f4e0000b029018bbd1875b7mr18823672pfd.48.1606750575955; Mon, 30 Nov 2020 07:36:15 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n2sm17092942pfq.129.2020.11.30.07.36.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 07:36:14 -0800 (PST) To: "devel@edk2.groups.io" Cc: Leif Lindholm From: "Rebecca Cran" Subject: ECC tool incorrectly reports that include guards must have prefix and postfix underscores Message-ID: Date: Mon, 30 Nov 2020 08:36:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US I came across what appears to be a bug in the ECC tool. I was running my bhyve changes through a personal EDK2 Github build, and ECC failed with the ERROR_NAMING_CONVENTION_CHECK_IFNDEF_STATEMENT: ./Source/Python/Ecc/EccToolError.py:164: ERROR_NAMING_CONVENTION_CHECK_IFNDEF_STATEMENT : "The #ifndef at the start of an include file should use both prefix and postfix underscore characters, '_'" It appears the tool really only checks that there's at least one underscore, so it seems it does _allow_ the style documented in the C coding standard (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files#5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard), which has a postfix underscore but which explicitly disallows prefix underscore(s). I've created https://bugzilla.tianocore.org/show_bug.cgi?id=3094 . -- Rebecca Cran