From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11383740032 for ; Thu, 14 Sep 2023 07:59:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WBMIS/NUIfSxvDXu5rXq+J26PXE84M5c+f/6XCeV7GE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694678360; v=1; b=fbtNbZoUEz8izbVB4ZGsf08DBTH5Z0FIDteXGfG2QhKU1/zsLshGYqzXx/xaIcHHuAP3+ma9 vjU9uu1AipYWhGYpr8WAsuK7HZIocCokIJUjqXT1ZeGpUOvy8q5RskATplFYeirnoXdoeax7qUZ t+/2wl8HbCliaYI+OW08b3Gc= X-Received: by 127.0.0.2 with SMTP id yLJBYY7687511xcHjlijuOnn; Thu, 14 Sep 2023 00:59:20 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.6821.1694678359951076567 for ; Thu, 14 Sep 2023 00:59:20 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-4omRrQqiNSSw62qZY3MPGA-1; Thu, 14 Sep 2023 03:59:16 -0400 X-MC-Unique: 4omRrQqiNSSw62qZY3MPGA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D606C185A790; Thu, 14 Sep 2023 07:59:14 +0000 (UTC) X-Received: from [10.39.194.12] (unknown [10.39.194.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 809B11054FC0; Thu, 14 Sep 2023 07:59:13 +0000 (UTC) Message-ID: Date: Thu, 14 Sep 2023 09:59:12 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/3] OvmfPkg/RiscVVirt/README: explain that "-bios" is only useful with TCG To: Andrew Jones Cc: edk2-devel-groups-io , Andrei Warkentin , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Sunil V L References: <20230913105551.12680-1-lersek@redhat.com> <20230913105551.12680-2-lersek@redhat.com> <20230913-cece398bba5d3bda329c7b2d@orel> From: "Laszlo Ersek" In-Reply-To: <20230913-cece398bba5d3bda329c7b2d@orel> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QHykE1OazqQEzqqyUkxWKwcLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fbtNbZoU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/13/23 18:28, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: >> Riscv64 KVM services SBI calls internally, so OpenSBI is not used in suc= h >> setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. >> >> Cc: Andrei Warkentin >> Cc: Andrew Jones >> Cc: Ard Biesheuvel >> Cc: Gerd Hoffmann >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Sunil V L >> Signed-off-by: Laszlo Ersek >> --- >> OvmfPkg/RiscVVirt/README.md | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md >> index dbb40bbe89b0..193e4afe8dee 100644 >> --- a/OvmfPkg/RiscVVirt/README.md >> +++ b/OvmfPkg/RiscVVirt/README.md >> @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following = additional command line >> option: >> =20 >> -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin >> + >> +Note that the above only makes a difference with software emulation (wh= ich you >> +can force with `-M accel=3Dtcg`). With hardware virtualization (`-M acc= el=3Dkvm`), >> +KVM services the SBI (Supervisor Binary Interface) calls internally, th= erefore >> +any externally loaded OpenSBI binary is ignored. >> >=20 > With the 'virt' machine model -bios is actually forbidden with accel=3Dkv= m, > not just ignored. Thanks, I think I should then say: therefore any OpenSBI binary specified with `-bios` is rejected (I think I can still technically merge this series myself on github, once it's been reviewed, so I could fix this up, to keep the churn low for the maintainers.) Unfortunately, I can't test KVM here; got no riscv64 hardware. (And I'm not really considering nesting KVM under TCG! :) Even if TCG emulated the virtualization extensions (?), the speed would probably be unbearable.) >=20 > Otherwise, >=20 > Reviewed-by: Andrew Jones >=20 > Thanks, > drew >=20 Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108641): https://edk2.groups.io/g/devel/message/108641 Mute This Topic: https://groups.io/mt/101334264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-