Re: [PATCH v2 10/17] OvmfPkg/PvScsiDxe: Enable MMIO-Space & Bus-Mastering in PCI attributes

["Laszlo Ersek" <lersek@redhat.com>]

On 03/25/20 17:09, Liran Alon wrote:
> Enable MMIO-Space & Bus-Mastering PCI attributes when device is started.
> Note that original PCI attributes are restored when device is stopped.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
>  OvmfPkg/PvScsiDxe/PvScsi.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c
> index 5566b4cce467..531bed4e5ab7 100644
> --- a/OvmfPkg/PvScsiDxe/PvScsi.c
> +++ b/OvmfPkg/PvScsiDxe/PvScsi.c
> @@ -305,8 +305,18 @@ PvScsiSetPciAttributes (
>    }
>  
>    //
> -  // TODO: Change PCI Attributes
> +  // Enable MMIO-Space & Bus-Mastering
>    //
> +  Status = Dev->PciIo->Attributes (
> +                         Dev->PciIo,
> +                         EfiPciIoAttributeOperationEnable,
> +                         (EFI_PCI_IO_ATTRIBUTE_MEMORY |
> +                          EFI_PCI_IO_ATTRIBUTE_BUS_MASTER),
> +                         NULL
> +                         );
> +  if (EFI_ERROR (Status)) {
> +    return Status;
> +  }
>  
>    return EFI_SUCCESS;
>  }
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>