Re: [PATCH] Maintainers.txt: Change package maintainer and reviewer of CryptoPkg.

[Laszlo Ersek <lersek@redhat.com>]

Hi Ting,

On 12/13/18 08:41, tye1 wrote:
> Cc: Gang Wei <gang.wei@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ting Ye <ting.ye@intel.com>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 001d8ba010..d5cb305da9 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -102,8 +102,9 @@ S: Maintained
>  
>  CryptoPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
> -M: Qin Long <qin.long@intel.com>
>  M: Ting Ye <ting.ye@intel.com>
> +R: Gang Wei <gang.wei@intel.com>
> +R: Jian Wang <jian.j.wang@intel.com>
>  
>  DynamicTablesPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/DynamicTablesPkg
> 

This patch does not conform to the rule that we added lately; please see
commit 9ebef6c0a7d3 ("Maintainers.txt: Add the rule to hand over the
package maintain role", 2018-11-29).

In other words, the patch should be sent out by Qin Long. Even though
you co-maintain CryptoPkg with Qin Long, you shouldn't be able to
deprive Qin Long from the role.

Thanks,
Laszlo