From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ankur.a.arora@oracle.com
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Aaron Young <aaron.young@oracle.com>
Subject: Re: [edk2-devel] [PATCH v8 01/10] OvmfPkg/CpuHotplugSmm: refactor hotplug logic
Date: Mon, 22 Feb 2021 12:49:49 +0100 [thread overview]
Message-ID: <f2ba4da4-b830-1b3e-3b28-21d7540aed74@redhat.com> (raw)
In-Reply-To: <20210222071928.1401820-2-ankur.a.arora@oracle.com>
On 02/22/21 08:19, Ankur Arora wrote:
> Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into
> ProcessHotAddedCpus(). This is in preparation for supporting CPU
> hot-unplug.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Aaron Young <aaron.young@oracle.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132
> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> Addresses these review comments from v6:
> (1) s/EFI_ERROR(/EFI_ERROR (/
> (2) Remove the empty line in the comment block above
> ProcessHotAddedCpus().
> () Nest the EFI_ERROR handling inside the (PluggedCount > 0) clause.
>
> OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 210 ++++++++++++++++++++++---------------
> 1 file changed, 126 insertions(+), 84 deletions(-)
OK, this is identical to the v7 counterpart.
Thanks
Laszlo
next prev parent reply other threads:[~2021-02-22 11:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 7:19 [PATCH v8 00/10] support CPU hot-unplug Ankur Arora
2021-02-22 7:19 ` [PATCH v8 01/10] OvmfPkg/CpuHotplugSmm: refactor hotplug logic Ankur Arora
2021-02-22 11:49 ` Laszlo Ersek [this message]
2021-02-22 7:19 ` [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events Ankur Arora
2021-02-22 12:27 ` [edk2-devel] " Laszlo Ersek
2021-02-22 22:03 ` Ankur Arora
2021-02-23 16:44 ` Laszlo Ersek
2021-02-22 7:19 ` [PATCH v8 03/10] OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper Ankur Arora
2021-02-22 12:31 ` [edk2-devel] " Laszlo Ersek
2021-02-22 22:22 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 04/10] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() Ankur Arora
2021-02-22 12:39 ` [edk2-devel] " Laszlo Ersek
2021-02-22 22:22 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 05/10] OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA Ankur Arora
2021-02-22 13:06 ` [edk2-devel] " Laszlo Ersek
2021-02-22 22:33 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 06/10] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state Ankur Arora
2021-02-22 14:19 ` [edk2-devel] " Laszlo Ersek
2021-02-23 7:37 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler Ankur Arora
2021-02-22 14:53 ` [edk2-devel] " Laszlo Ersek
2021-02-23 7:37 ` Ankur Arora
2021-02-23 16:52 ` Laszlo Ersek
2021-02-23 7:45 ` Paolo Bonzini
2021-02-23 17:06 ` Laszlo Ersek
2021-02-23 17:18 ` Paolo Bonzini
2021-02-23 20:46 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 08/10] OvmfPkg/CpuHotplugSmm: add EjectCpu() Ankur Arora
2021-02-23 20:36 ` [edk2-devel] " Laszlo Ersek
2021-02-23 20:51 ` Ankur Arora
2021-02-22 7:19 ` [PATCH v8 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject Ankur Arora
2021-02-23 21:39 ` [edk2-devel] " Laszlo Ersek
2021-02-24 3:44 ` Ankur Arora
2021-02-25 19:22 ` Laszlo Ersek
2021-02-22 7:19 ` [PATCH v8 10/10] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug Ankur Arora
2021-02-23 21:52 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ba4da4-b830-1b3e-3b28-21d7540aed74@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox