From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 03:44:34 -0700 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 718F011A1F for ; Tue, 24 Sep 2019 10:44:34 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id g82so737985wmg.9 for ; Tue, 24 Sep 2019 03:44:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SjmQ0A49HOrDwtoOn9ICz5nbbASlN/xSE/s1Q3ec6bA=; b=j6C8cc1y5B0zqPg5yDcfF0ghdUxpOHNlHhAinFBRJE139wdHEEQQHezkKTWo9kpppN T3r/GQfE/s+qiM7Xjdm2o6t+/MrRj1zOE4MfeKBsLrSilw7XCZsPwJA1JYdN98Y0j6jM mTlZ401lC62dQrSAynWFx8Lqwp4EUedADaVfPyWXROEuZLq7c6ZD2mMB4nratvFSRYfg E2GtOrUgoS0veU0Wi4X/pBPvstuURR4rjNB4ggQNJwiVfqIRM4X+gLDV2nQ3AsY6duCn sH7u2a6fvFP3Ybj/T7pJyI/nsgtvwddi8t037We3m+b3WE9ACDDspDNqobYwF96HIhtI QnPw== X-Gm-Message-State: APjAAAUgL0sCoaAp+G9v+LLsoaRundqMz3ZJlAYGX8sBIkFsK8ULfjsQ 8hqV/4TpFiD1fO3rMMzAnmnpQme5VqUq/iQshFrnFbU5oPSIWHrzesOl0WoVJbm5gp+stoYuKmZ ymv6WnEJ6jPKanQ== X-Received: by 2002:a1c:c915:: with SMTP id f21mr2121517wmb.65.1569321873100; Tue, 24 Sep 2019 03:44:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/qNXKBv/v1Qu3vX2/fpa8QF6HREE137b4M6RMZdrUGWebF5DJ4UvEMA+9uNBKLfbYZglqdw== X-Received: by 2002:a1c:c915:: with SMTP id f21mr2121508wmb.65.1569321872846; Tue, 24 Sep 2019 03:44:32 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id o9sm2790527wrh.46.2019.09.24.03.44.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 03:44:32 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke notify registration To: devel@edk2.groups.io, lersek@redhat.com Cc: Andrew Fish , Jordan Justen , Ray Ni References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-7-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 24 Sep 2019 12:44:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-7-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require > the notification handle to have type (VOID*). The notification handle has > nothing to do with the EFI_HANDLE type. > > This change is a semantic fix; functionally, it's a no-op. > > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Ray Ni > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmulatorPkg/EmuGopDxe/GopInput.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/GopInput.c > index fdd0b4911555..2a23564a2173 100644 > --- a/EmulatorPkg/EmuGopDxe/GopInput.c > +++ b/EmulatorPkg/EmuGopDxe/GopInput.c > @@ -517,7 +517,7 @@ EmuGopSimpleTextInExRegisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > IN EFI_KEY_DATA *KeyData, > IN EFI_KEY_NOTIFY_FUNCTION KeyNotificationFunction, > - OUT EFI_HANDLE *NotifyHandle > + OUT VOID **NotifyHandle > ) > { > EFI_STATUS Status; > @@ -600,7 +600,7 @@ EFI_STATUS > EFIAPI > EmuGopSimpleTextInExUnregisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > - IN EFI_HANDLE NotificationHandle > + IN VOID *NotificationHandle > ) > /*++ > > Reviewed-by: Philippe Mathieu-Daude