From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
To: Joseph Hemann <joseph.hemann@arm.com>, devel@edk2.groups.io
Cc: Joseph Hemann <Joseph.heman@arm.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Eric Jin <eric.jin@intel.com>, Irene Park <ipark@nvidia.com>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Stuart Yoder <Stuart.Yoder@arm.com>
Subject: Re: [PATCH v1] uefi-sct/SctPkg: Changed compiler check from greater 5 to equal to 5
Date: Mon, 14 Dec 2020 15:59:52 +0100 [thread overview]
Message-ID: <f2cf4127-2874-6609-2da1-8287d62fd64b@gmx.de> (raw)
In-Reply-To: <20201214143546.47522-1-joseph.hemann@arm.com>
On 14.12.20 15:35, Joseph Hemann wrote:
> From: Joseph Hemann <Joseph.heman@arm.com>
>
> gcc compilers versions 5.* also need to be converted from string to integer before testing
>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Cc: Irene Park <ipark@nvidia.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Stuart Yoder <Stuart.Yoder@arm.com>
> Signed-off-by: Joseph Hemann <Joseph.heman@arm.com>
> Change-Id: Ica60b6629f698d5f5c61b861ac4aefcc9cd24b7a
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> uefi-sct/SctPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
> index 37667711..ba9babe7 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,7 +56,7 @@ function get_gcc_version
> {
> gcc_version=$($1 -dumpversion)
>
> - if [ ${gcc_version%%.*} -gt 5 ]; then
> + if [ ${gcc_version%%.*} -ge 5 ]; then
> gcc_version=5
> fi
>
>
next prev parent reply other threads:[~2020-12-14 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 14:35 [PATCH v1] uefi-sct/SctPkg: Changed compiler check from greater 5 to equal to 5 Joseph Hemann
2020-12-14 14:59 ` Heinrich Schuchardt [this message]
2021-01-05 15:18 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2cf4127-2874-6609-2da1-8287d62fd64b@gmx.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox