From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout.gmx.net (mout.gmx.net [212.227.15.15])
 by mx.groups.io with SMTP id smtpd.web09.35931.1607958010476046591
 for <devel@edk2.groups.io>;
 Mon, 14 Dec 2020 07:00:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=BeRIaORW;
 spf=pass (domain: gmx.de, ip: 212.227.15.15, mailfrom: xypron.glpk@gmx.de)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
	s=badeba3b8450; t=1607958001;
	bh=NeafCYMCA/FSNBzqtGjmRZrkXRTYDyY7cnfowkVf4to=;
	h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
	b=BeRIaORWzUpXut9exUZWxpWFX3YoReEK+DD9oDSiv7WSooq9e7QLANi7x8/UmCv94
	 frMW1r4P3FdGHNMAmqeYYHlQKDsP9QJijJ+3wVX4SBSvJlsQoAPIDLLTswnd+0n13/
	 8fiH39Zkrzlh0HHj8gH82VShWiMMhOrpprN18ouM=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.123.70] ([62.143.246.89]) by mail.gmx.com (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Msq6M-1k0I0m3mwK-00tGjx; Mon, 14
 Dec 2020 16:00:00 +0100
Subject: Re: [PATCH v1] uefi-sct/SctPkg: Changed compiler check from greater 5 to equal to 5
To: Joseph Hemann <joseph.hemann@arm.com>, devel@edk2.groups.io
Cc: Joseph Hemann <Joseph.heman@arm.com>,
 G Edhaya Chandran <Edhaya.Chandran@arm.com>, Eric Jin <eric.jin@intel.com>,
 Irene Park <ipark@nvidia.com>,
 Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
 Stuart Yoder <Stuart.Yoder@arm.com>
References: <20201214143546.47522-1-joseph.hemann@arm.com>
From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
Message-ID: <f2cf4127-2874-6609-2da1-8287d62fd64b@gmx.de>
Date: Mon, 14 Dec 2020 15:59:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <20201214143546.47522-1-joseph.hemann@arm.com>
X-Provags-ID: V03:K1:jp8SrWw3VysYIGDGSHlvWxkX/Ue5niRwOMzXOQcs78IuBA8vp2t
 T8lTHtUAo9/e+IgSYmKfVoDVst2TJkLwGUwNlqTCruKKreL3Jtjx8uyZd13doBEiSZgss4S
 HHoEGrpGcMCiLU5N1NY0NmXr+7l1xJN7d/uzm+A93w2lTO+3WqzbA4ltxa7mcz3AkCqTPOB
 elnbLUyzSVtg8fqwcWXQw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:PNjbIZevO4o=:0mnmu5iTJpPO4kw6rQitRl
 96FLYxCNLASLguhyVE6f7dGcDi7kyO/ivwJdO/SL109vvM/eiS2tpGHKwC98KBwl4pRIWQZBq
 jSjh3UbD2+CRKt+PSeE3PeYj4Bf5LhlKr9Y5uZSF5EhsfHnWekdMhYBYvWCu+o4mfrmjRLC7H
 amG/M41X+oQXWpGcS271t/gR18TuOfeHX0/wYDF/tkUBOsXMSrkq3CarYMmp7HU5PWL0vzv8o
 5K7Fr9jnRO6CPzJ18cQO8KYBCFcyL30OL9A4zzGtCsFbgpBAKdslhXBc+0QpR44p6QFju8+A3
 8B8AVkCvhVKeFcbGSw/JDxgtdmQ5yZihh94f/XF1mmdUybgXg3cgwozbMg5QiaEkdLvIurS89
 C6byFNSvJI9nDz+cAEBwbFQmmfIJK9JDHzC0iTQpuD80nUguWNYkGikb1ZCdGrIMuw7Plyk3g
 9l9+trlkE+7AfIridROwztRbDjC4qRFD/VolZC/Bc5DcUrINtPzdK41cmth5EmtqIqBlVPous
 1jxfOZ/4vcG48mnithI3VZBfCeLvrwhNJkyaqjrWJEqC/RCPtAYVbdp5xI8s6IdvOmy/pWpKM
 WF6aELRzA57aXctsPHMBjs8n+Za6K43G3aEUpuE10xfTFj2wJ9qE89WpbT3poUkCHngUinJVS
 LySJW4XmrPqlKNCdWRVOklUoapZe5jGJeHfjAPGh4vqz7WQa3O3+NBNV6hb0lWhzbz5+nWZpw
 TTqqe09TAjTKQTHsUCNJv1nxWh3aw74/lzdiGhf7d2yLx/muBKSVFf5LXIqpvtrI76XO1zsJY
 7eQogesTyigYb56HZSzau9tEGtBQGkfDv+hjj9Im43oRiRGz+Z7MFZkUqLc2HwYfn8ti3vbDe
 K7S/uQO4d1AppIFc5BzQ==
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 14.12.20 15:35, Joseph Hemann wrote:
> From: Joseph Hemann <Joseph.heman@arm.com>
>
> gcc compilers versions 5.* also need to be converted from string to inte=
ger before testing
>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Cc: Irene Park <ipark@nvidia.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Stuart Yoder <Stuart.Yoder@arm.com>
> Signed-off-by: Joseph Hemann <Joseph.heman@arm.com>
> Change-Id: Ica60b6629f698d5f5c61b861ac4aefcc9cd24b7a

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>  uefi-sct/SctPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
> index 37667711..ba9babe7 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,7 +56,7 @@ function get_gcc_version
>  {
>  	gcc_version=3D$($1 -dumpversion)
>
> -	if [ ${gcc_version%%.*} -gt 5 ]; then
> +	if [ ${gcc_version%%.*} -ge 5 ]; then
>  		gcc_version=3D5
>  	fi
>
>