Re: [Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg.

[Laszlo Ersek <lersek@redhat.com>]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to Tcp4Dxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/TcpDxe/TcpDxe.inf | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/TcpDxe/TcpDxe.inf b/NetworkPkg/TcpDxe/TcpDxe.inf
> index eb693a147f..56cfd16b98 100644
> --- a/NetworkPkg/TcpDxe/TcpDxe.inf
> +++ b/NetworkPkg/TcpDxe/TcpDxe.inf
> @@ -1,12 +1,17 @@
>  ## @file
>  #  TCPv4 I/O and TCPv6 I/O services.
>  #
>  #  This module provides EFI TCPv4 Protocol and EFI TCPv6 Protocol to send and receive data stream.
> -#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on
> -#  which network stack has been loaded in system.
> +#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on which network 
> +#  stack has been loaded in system. This driver supports both IPv4 and IPv6 network stack.
>  #
> +#  Notes: 
> +#  1) This driver can't co-work with the Tcp4Dxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, TCP Cancel 

suggestion: "bugs fix" --> "bug fixes"

> +#     function) than the Tcp4Dxe driver in MdeModulePkg. So, we recommand to use this driver 

suggestion: "recommand to use" --> "recommend using"

> +#     even both of them can be used.

"even" --> "even though"

With those:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

>  #
>  #  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
>